trac-admin $ENV ticket_changesets commands fail w/ Trac 0.12

[Dennis McRitchie <dmcr@…>]

When running any of the trac-admin $ENV ticket_changesets commands, the results are always:

trac-admin $ENV ticket_changesets diff
diff ticket commit messages to be reformatted
OperationalError: (1054, "Unknown column 'rowid' in 'field list'")

The column 'rowid' is no longer present in the ticket_change table. The patch below is a suggested fix:

diff admin.py.orig admin.py
195c195
<             cursor.execute('SELECT rowid,ticket,oldvalue,newvalue '
---
>             cursor.execute('SELECT ticket,time,oldvalue,newvalue '
198c198
<                 rowid, ticket, oldvalue, oldmessage = row
---
>                 ticket, time, oldvalue, oldmessage = row
210,211c210,211
<                                            'SET newvalue=%s WHERE rowid=%s',
<                                            [newmessage, rowid])
---
>                                            'SET newvalue=%s WHERE ticket=%d AND time=%d',
>                                            [newmessage, ticket, time])
213c213
<                             printout('@@ comment:%s:ticket:%s (db rowid %s) @@'
---
>                             printout('@@ comment:%s:ticket:%d (db time %d) @@'

[William D Hill]

The patch listed is missing an extra change for line 214.

214c214 < % (oldvalue, ticket, rowid)) ---

% (oldvalue, ticket, time))

[William D Hill]

This patch is a better one to use. The previous one made some incorrect assumptions in line 210, and wouldn't work. This one includes the amendment I added, and has been tested.

Cheers.

195c195
<             cursor.execute('SELECT rowid,ticket,oldvalue,newvalue '
---
>             cursor.execute('SELECT ticket,time,oldvalue,newvalue '
198c198
<                 rowid, ticket, oldvalue, oldmessage = row
---
>                 ticket, time, oldvalue, oldmessage = row
210,211c210,211
<                                            'SET newvalue=%s WHERE rowid=%s',
<                                            [newmessage, rowid])
---
>                                            'SET newvalue=%s WHERE ticket=%s and time=%s',
>                                            [newmessage, ticket, time])
213,214c213,214
<                             printout('@@ comment:%s:ticket:%s (db rowid %s) @@'
<                                      % (oldvalue, ticket, rowid))
---
>                             printout('@@ comment:%s:ticket:%d (db time %d) @@'
>                                      % (oldvalue, ticket, time))

[Jiri]

Hi,

I just got the code from subversion, still with this bug.

​http://trac-hacks.org/svn/tracticketchangesetsplugin/trunk/

When will this patch get in the code?

[Jiri Hoogeveen]

And I can confirm that this patch works. Testen with trac 0.12.2

[Mikael Relbe]

(In [9996]) Fixes #7383 (trac-admin $ENV ticket_changesets commands fail w/ Trac 0.12)

Patch provided by Dennis McRitchie <dmcr@…> and daul.hill@….

Thanks!

(I beg your pardon for the ridiculous long delay of getting this into the repo.)