Modify

Opened 7 years ago

Last modified 7 years ago

#7528 new defect

Summit comment button hanging in firefox 3

Reported by: Peter Owned by: Odd Simon Simonsen
Priority: normal Component: AddCommentMacro
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

I seem to have an issues with using the AddCommentMacro plugin with trac 0.12 under Firefox. When I click on the AddComment button the page does not get refreshed and Firefox seems to be waiting for data. The problem just seems to be related to the page refresh since the comment does get added to the wiki. Using Internet explorer everything works as expected.

As a temporary fix I commented out the following code in macro.py...

# We can't redirect from macro as it will raise RequestDone
                    # which like other macro errors gets swallowed in the Formatter.
                    # We need to re-raise it in a post_process_request instead.
                    #try:
                    #    self.env.log.debug(
                    #        "AddComment saved - redirecting to: %s" % page_url)
                    #    req._outheaders = []
                    #    req.redirect(page_url)
                    #except RequestDone:
                    #    req.addcomment_raise = True

and inserted this below the above code...

                    the_preview = tag.div(heading,
                                format_to_html(self.env, context, comment),
                                class_="wikipage", id="preview")
                    the_message = tag.div(tag.strong("Comment appended."),class_="system-message")
                    comment=""

Thanks

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by Peter

Summary: AddCommentMacro firefoxSummit comment button hanging in firefox 3

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Odd Simon Simonsen.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.