[patch] Clicking notification checkbox doesn't toggle notification status (in chrome)

[Pontus Enmark]

watchlistplugin/tracwatchlist/htdocs/js/watchlist.dev.js

@@ -63 +63 @@
     return false;
   });
 
+  $('a.notifyon input, a.notifyoff input').click(function(e) {
+    window.location = $(this).parent().attr('href')
+  })
 });

[Martin Scharrer]

Please give more information. Which exact version of the WatchlistPlugin are you using? I would also need the version of chrome and your OS.

Could you try this with the current dev branch if you use Trac 0.12 or with the dev branch in r8430 if you use Trac 0.11. Should be fixed there using AJAX calls.

[Martin Scharrer]

I now [8724] updated the dev branch to be again compatible to Trac 0.11. I tested this version with both Trac 0.11 and 0.12 and Google Chrome 6.0.472.55 under Ubuntu Linux 10.04. It works fine so I mark this ticket now as worksforme.

Feel free to install the above develop version or wait for the next official release which should come soon (next few weeks).

[Pontus Enmark]

Sorry missed to set the correct trac version. The watchlistplugin is 0.12 @8582. My OS is Ubuntu 10.04 and I use Chrome 6.0.472.55-r58392. The problem was

<a href="toggle notify"><input type="checkbox"></a>

At least in chrome, clicking just outside the checkbox causes the link to be clicked, clicking the checkbox doesn't propagate to the anchor element.

[Martin Scharrer]

I installed the current 0.12 branch now and tested it with Google Chrome. I could recreate your issue -- so it isn't a worksforme after all :-) .

However, this is fixed in the current dev branch so comment:2 still applies.

Thanks for reporting this, even it was fixed in the meantime.

[Martin Scharrer]

Just had a look on the relevant JS-code again and figured out, that the toggling of the notification wasn't correctly supported! :-) While the check-box got toggled only the initial action (either 'notifyon' or 'notifyoff') was send every time.

I fixed this now in [8727] in dev.