Modify

Opened 6 years ago

Closed 4 months ago

Last modified 4 months ago

#7834 closed defect (fixed)

Emails are attempted to be sent even when there are no recipients

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: email notification
Cc: Ryan J Ollos, Robert Corsaro Trac Release: 0.12

Description (last modified by Steffen Hoffmann)

Before starting delivery, EmailDistributor._do_send should check the length of recip_adds and only send email, if there are actually recipients.

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by Steffen Hoffmann

Cc: Ryan J Ollos Robert Corsaro added; anonymous removed
Description: modified (diff)
Keywords: email notification added
Owner: changed from Robert Corsaro to Steffen Hoffmann

comment:2 Changed 4 years ago by Steffen Hoffmann

(In [12326]) TracAnnouncer: Don't attempt email distribution without recipients, refs #7834.

Felt like a re-arranged and slightly simplified code would make it easier to implement the requested check in EmailDistributor._do_send. IMHO it did.

comment:3 Changed 4 years ago by Steffen Hoffmann

But events without subscription won't even fire EmailDistributor, so I'm currently at a loss, how to test this. Ideas?

comment:4 Changed 4 months ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

comment:5 Changed 4 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:6 Changed 4 months ago by Ryan J Ollos

Owner: set to Steffen Hoffmann

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.