Modify

Opened 6 years ago

Closed 6 weeks ago

Last modified 6 weeks ago

#7834 closed defect (fixed)

Emails are attempted to be sent even when there are no recipients

Reported by: anonymous Owned by: hasienda
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: email notification
Cc: rjollos, doki_pen Trac Release: 0.12

Description (last modified by hasienda)

Before starting delivery, EmailDistributor._do_send should check the length of recip_adds and only send email, if there are actually recipients.

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by hasienda

  • Cc rjollos doki_pen added; anonymous removed
  • Description modified (diff)
  • Keywords email notification added
  • Owner changed from doki_pen to hasienda

comment:2 Changed 4 years ago by hasienda

(In [12326]) TracAnnouncer: Don't attempt email distribution without recipients, refs #7834.

Felt like a re-arranged and slightly simplified code would make it easier to implement the requested check in EmailDistributor._do_send. IMHO it did.

comment:3 Changed 4 years ago by hasienda

But events without subscription won't even fire EmailDistributor, so I'm currently at a loss, how to test this. Ideas?

comment:4 Changed 7 weeks ago by rjollos

  • Owner hasienda deleted

comment:5 Changed 6 weeks ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 6 weeks ago by rjollos

  • Owner set to hasienda

Add Comment

Modify Ticket

Action
as closed The owner will remain hasienda.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.