Modify

Opened 11 years ago

Closed 11 years ago

#80 closed defect (fixed)

IAccountChangeListener method name incorrect

Reported by: Alec Thomas Owned by: anonymous
Priority: normal Component: AccountManagerPlugin
Severity: minor Keywords:
Cc: Trac Release:

Description

So I finally got around to adding the new user hooks into TracHacks and came across this minor bug. Fix below.

  • acct_mgr/api.py

     
    5050    """An interface for receiving account change events.
    5151    """
    5252
    53     def user_added(self, user, password):
     53    def user_created(self, user, password):
    5454        """New user
    5555        """

After this change, it all worked beautifully. When they register, new users automatically get a basic user page created with the user tag. It's a beautiful thing.

Attachments (0)

Change History (4)

comment:1 Changed 11 years ago by Matt Good

Owner: changed from Matt Good to anonymous
Status: newassigned

The methods defined in the interface are really just for documentation, so as long as your implementation uses the right name then it will work. However, that probably would confuse some people. I'll update this soon.

comment:2 Changed 11 years ago by Alec Thomas

Yes, this is exactly what happened...I copy and pasted the listener methods and was surprised to see it not work.

comment:3 Changed 11 years ago by Alec Thomas

milestone: 0.9.1

Milestone 0.9.1 deleted

comment:4 Changed 11 years ago by Matt Good

Resolution: fixed
Status: assignedclosed

(In [706]) fix the method name of user_created in IAccountChangeListener (fixes #80)

Modify Ticket

Action
as closed The owner will remain anonymous.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.