Opened 5 years ago

Closed 21 months ago

Last modified 21 months ago

#8119 closed enhancement (invalid)

Include pages referenced in commit messages

Reported by: Olaf Meeuwissen <olaf.meeuwissen@…> Owned by: glinders
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11


We find ourselves referencing wiki pages in our commit messages quite a bit. Occasionally, we refer to pages we mean to write in the near future but never get around to doing so. A visual reminder in the list of wanted pages would be neat.

Attachments (0)

Change History (5)

comment:1 Changed 2 years ago by rjollos

  • Owner changed from jfrancis to rjollos
  • Status changed from new to assigned

comment:2 Changed 2 years ago by rjollos

  • Component changed from WantedPagesPlugin to WantedPagesMacro

Renaming plugin from WantedPagesPlugin to WantedPagesMacro.

comment:3 Changed 2 years ago by rjollos

  • Owner changed from rjollos to glinders

Reassigning tickets to glinders, assuming adoption request in #11491 will be approved.

comment:4 Changed 21 months ago by glinders

  • Resolution set to invalid
  • Status changed from assigned to closed

The scope of WantedPagesMacro is to find links to missing wiki pages referenced by other wiki pages. Commit messages are part of the version control system and as such are out of the scope of this macro.

I propose to close this ticket as invalid.

Please let me know if I misinterpreted the request.

comment:5 Changed 21 months ago by olaf.meeuwissen@…

While I understand your point about commit messages being part of the VCS, they are also visible in the timeline by default and with very little effort in the tickets referenced in the commit message.

From the WantedPagesMacro description:

Lists all wiki pages that are linked to but not created in wikis, ticket descriptions and ticket comments. That is, when a camel-case identifier is listed in a wiki page, then a link is created to that page, but if that page does not exist then the link exists but the page is not created.

So it sounds like tickets are part of the scope too (or the description needs fixing). In that case and since our commit messages end up on any ticket pages they reference, any wiki pages referred to but not yet created should normally be picked up by the WantedPagesMacro. We'd miss out though on messages that don't refer to a ticket. This kind of partial coverage of commit messages would be somewhat surprising. Of course, requiring all commit messages to mention a ticket would fix this. Still, it'd be nice if such a local policy would not be needed.

BTW, it would be nice if the timeline could be included in the scope too, seeing that that includes commit messages by default.

Add Comment

Modify Ticket

as closed The owner will remain glinders.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.