Modify ↓

Opened 14 years ago

Closed 12 years ago

#8286 closed defect (fixed)

Make proper use of the Trac database API

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: high Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Olemis Lang Trac Release: 0.11

Description

The dbEscape function is entirely unnecessary with proper use of the Trac DB API. All of the queries in this plugin need to be rewritten. See ​t:TracDev/DatabaseApi for more information.

Attachments (0)

Change History (6)

comment:1 Changed 14 years ago by Ryan J Ollos

Owner: changed from Sebastian Marek to Ryan J Ollos
Status: new → assigned

comment:2 Changed 14 years ago by Ryan J Ollos

Priority: normal → high

comment:3 Changed 13 years ago by Marc

Owner: changed from Ryan J Ollos to Marc
Status: assigned → new

comment:4 Changed 12 years ago by Ryan J Ollos

Owner: changed from Marc to Ryan J Ollos
Type: task → defect

comment:5 Changed 12 years ago by Ryan J Ollos

Cc: Olemis Lang added; anonymous removed
Status: new → assigned

The 2.2dev branch was moved to the trunk in [11987], and this issue was mostly fixed in the 2.2dev branch. I'll follow with a small commit.

comment:6 Changed 12 years ago by Ryan J Ollos

Resolution: → fixed
Status: assigned → closed

(In [12477]) Fixes #8286:

  • Removed obsolete dbEscape function and unnecessary imports.
  • Formatted some SQL statements per Trac guidelines (1).

(1) ​trac:TracDev/DatabaseApi#GuidelinesforSQLStatements

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.