Modify

Opened 6 years ago

Closed 6 years ago

#8352 closed defect (fixed)

[Patch] Chinese character in wiki name cause UnicodeEncodeError

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: TagsPlugin
Severity: normal Keywords: unicode
Cc: Trac Release: 0.12

Description

See attachment:Screenshot.png for detail, the screenshot's url is http://.../test/tags?q='testing' .

The patch for this ploblem is the attachment file macros.py(see line 81), for your reference.

Attachments (2)

Screenshot.png (135.2 KB) - added by anonymous 6 years ago.
The error screen
macros.py (3.2 KB) - added by anonymous 6 years ago.
The patch, for tractags-0.6-py2.5.egg

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by anonymous

Attachment: Screenshot.png added

The error screen

Changed 6 years ago by anonymous

Attachment: macros.py added

The patch, for tractags-0.6-py2.5.egg

comment:1 Changed 6 years ago by Ryan J Ollos

Summary: Chinese character in wiki name cause UnicodeEncodeError[Patch] Chinese character in wiki name cause UnicodeEncodeError

Please attach the patch as a diff.

comment:2 Changed 6 years ago by Steffen Hoffmann

Keywords: unicode added
Owner: changed from Michael Renzmann to Steffen Hoffmann

This is a patch for tagged branch 0.6 only. Thanks for reporting the issue and providing a possible fix as well.

Nevertheless adding a modified file instead of just the changes (unified diff) is considered bad communication style here. The Python version 2.5 is even irrelevant, but the exact description, where the macros.py has been taken from would save us valuable development time, as Ryan already suggested. Please take care.

I've extracted the changes and verified that trunk already has another solution in place.

comment:3 Changed 6 years ago by Steffen Hoffmann

(In [10385]) TagsPlugin: Allow Unicode wiki page names for ListTaggedMacro macro, refs #8352.

Thank you very much for the report including a possible solution alongside.

comment:4 Changed 6 years ago by Steffen Hoffmann

Status: newassigned

Please test the new revision and feel free to close this ticket with solution 'fixed', if appropriate. Thank you again for taking care.

comment:5 Changed 6 years ago by Ryan J Ollos

#8904 closed as a duplicate.

comment:6 Changed 6 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

At least, I think #8904 is a duplicate, or is a very similar issue anway. As I reported in that ticket, the issue with using 回退 as a tag seems to be fixed.

Using the same test case with the ListTagged macro indicates this issue is resolved as well.

Modify Ticket

Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.