Opened 13 years ago
Closed 13 years ago
#8381 closed defect (fixed)
Failure to verify valid passwords after migration Windows => FreeBSD
| Reported by: | Steffen Hoffmann | Owned by: | Steffen Hoffmann |
|---|---|---|---|
| Priority: | normal | Component: | AccountManagerPlugin |
| Severity: | critical | Keywords: | htpasswd file linebreak style |
| Cc: | Trac Release: | 0.11 |
Description
As I've been informed by Honza Rameš lately, there is potential portability issue in the current htfile.py code for 0.10 and 0.11 branch.
It arises from improper handling (.strip()) of lines read for password matching due to different EOL style in Windows and BSD (and of course other systems too).
The trunk branch is no affected, since this issue has been prevented by opening the password store file in unified mode since [9272].
Attachments (1)
Change History (3)
comment:1 Changed 13 years ago by
| Status: | new → assigned |
|---|---|
| Summary: | Unable to correctly verify valid passwords after migration Windows => FreeBSD → Failure to verify valid passwords after migration Windows => FreeBSD |
comment:2 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [9749]) AccountManagerPlugin: Prevent password matching failure for PasswordFileStores, closes #8381.
This is a reported portability issue, but the code change here is meant
as an interim/maintenance revision, before the issue with different
EOL styles across different OS platforms is addressed more general
by merging [9272] from trunk into the other branches.
Changed 13 years ago by
| Attachment: | htfile.patch added |
|---|
Original patch I submitted to Steffen during my research of the issue
As the aforementioned code is still not part of any stable release, I'll go and apply the suggested fix to still get some improvement for stable releases NOW.