Modify ↓

Opened 14 years ago

Closed 8 years ago

Last modified 8 years ago

#8576 closed enhancement (fixed)

Some patches to use more Trac built in features

Reported by: pipern Owned by: pipern
Priority: normal Component: TicketModifiedFilesPlugin
Severity: normal Keywords: patch
Cc: Trac Release: 0.12

Description (last modified by Ryan J Ollos)

Here is a patch to :

  • Use ListOption
  • Use add_warning()
  • Use add_ctxtnav()
  • Avoid unnecessary ITemplateStreamFilter
  • get_read_db()

Attachments (2)

ticketmodifiedfilesplugin-8576-1.patch​ (5.9 KB) - added by pipern 14 years ago.
Reduce amount of code by using Trac functions
ticketmodifiedfilesplugin-8576-2.patch​ (800 bytes) - added by pipern 14 years ago.
Use get_read_db() rather than get_db_cnx(), see ​http://trac.edgewall.org/wiki/TracDev/ApiChanges/0.12#get_db_cnx

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by pipern

Attachment: ticketmodifiedfilesplugin-8576-1.patch​ added

Reduce amount of code by using Trac functions

Changed 14 years ago by pipern

Attachment: ticketmodifiedfilesplugin-8576-2.patch​ added

Use get_read_db() rather than get_db_cnx(), see ​http://trac.edgewall.org/wiki/TracDev/ApiChanges/0.12#get_db_cnx

comment:1 Changed 13 years ago by Ryan J Ollos

Description: modified (diff)
Owner: changed from Emilien Klein to Ryan J Ollos
Trac Release: 0.11 → 0.12

comment:2 Changed 8 years ago by Ryan J Ollos

Status: new → accepted

comment:3 Changed 8 years ago by Ryan J Ollos

In 16487:

2.0.0dev: Use get_read_db() rather than get_db_cnx()

Patch by pipern.

Refs #8576.

comment:4 Changed 8 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 16488:

2.0.0dev: Refactor code

Patch by pipern.

Fixes #8576.

comment:5 Changed 8 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to pipern

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain pipern.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.