Modify

Opened 6 years ago

Closed 7 months ago

Last modified 7 months ago

#8577 closed defect (fixed)

NameError: when trying to delete a ticket

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: ticket TypeError
Cc: Trac Release: 0.12

Description (last modified by Ryan J Ollos)

I got this error in trunk:

Trac [/var/trac/tech]> ticket remove 4
NameError: global name 'page' is not defined

Hmm, couldn't copy/paste the patch here, so i will try to attach it as a file.

Attachments (1)

ticket8577.patch (1.9 KB) - added by jc-trachacks_AnnouncerPlugin@… 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by jc-trachacks_AnnouncerPlugin@…

Attachment: ticket8577.patch added

comment:1 Changed 5 years ago by Ryan J Ollos

#9154 closed as a duplicate, but proposes some alternate patches.

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:3 Changed 5 years ago by Ryan J Ollos

#7833 closed as a duplicate.

comment:4 Changed 5 years ago by Ryan J Ollos

#8065 closed as a duplicate, and it has a patch which we may want to review.

comment:5 in reply to:  1 ; Changed 5 years ago by Steffen Hoffmann

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

comment:6 in reply to:  5 ; Changed 5 years ago by Ryan J Ollos

Replying to hasienda:

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

Are you suggesting the patch in #9154 is better than the patch in this ticket? I hadn't looked closely enough to make a judgement.

comment:7 in reply to:  6 Changed 5 years ago by Steffen Hoffmann

Keywords: ticket TypeError added

Replying to rjollos:

Replying to hasienda:

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

Are you suggesting the patch in #9154 is better than the patch in this ticket? I hadn't looked closely enough to make a judgement.

Yes, indeed. While str() is more of hack, #9154 more accurately points at a dedicated method designed for the purpose. I've already integrated it into my patch stack and tests.

comment:8 Changed 5 years ago by Steffen Hoffmann

(In [12311]) AnnouncerPlugin: Further improve ticket permission checks, refs #5825, #8458 and #8577.

This is a late follow-up to changeset [9813] after more in-deep discussion on permission checking for whole Trac realms and specific Trac resources in #8458. With my original patch proposal from 04-Feb-2011 in mind I call this an aged and really matured changeset, and that's not so bad after all. Furthermore code from [12304] gets improved here as well.

Special thanks to Odd Simon Simonsen, Ryan J. Ollos and Christian Boos for their help on my way towards better understanding Trac permissions.

comment:9 Changed 2 years ago by Ryan J Ollos

Owner: Robert Corsaro deleted

comment:10 Changed 7 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:11 Changed 7 months ago by Ryan J Ollos

Owner: set to Steffen Hoffmann

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.