Modify ↓
      
        Opened 15 years ago
Closed 13 years ago
#8680 closed defect (fixed)
setup should not require ExtractUrlPlugin
| Reported by: | Owned by: | Ryan J Ollos | |
|---|---|---|---|
| Priority: | normal | Component: | ServerSideRedirectPlugin | 
| Severity: | normal | Keywords: | |
| Cc: | Trac Release: | 0.11 | 
Description
In setup.py the directive setup_requires = ['TracExtractUrl>=0.2.7030'] is set making egg building impossible on "non trac" machines. 
Without it ./setup.py bdist_egg will run fine, also installation at the target system with installed TracExtractUrl.
So if there's no other reason I'm not aware of enforcing setup_requires, please drop it.
Attachments (0)
Change History (3)
comment:1 Changed 13 years ago by
| Owner: | changed from Martin Scharrer to Ryan J Ollos | 
|---|
comment:2 Changed 13 years ago by
| Status: | new → assigned | 
|---|
- Seems to be working well with 1.0dev, so I added the 1.0 tag to the project wiki page.
- I had to change the import from from tracextracturl import extract_urltofrom tracextracturl.extracturl import extract_url. I think this could be avoided by modifying__init__.pyin ExtractUrlPlugin.
comment:3 Changed 13 years ago by
| Resolution: | → fixed | 
|---|---|
| Status: | assigned → closed | 
Note: See
        TracTickets for help on using
        tickets.
    



Yeah,
setup_requiresdoesn't seem to be needed. See setuptools documentation for more info. See also #6940.We are planning to use this plugin on trac-hacks, so I hope it is okay with the author if I go ahead and fix the issue.