Modify

Opened 6 years ago

Last modified 5 years ago

#8795 new defect

ticket number regex fails

Reported by: anonymous Owned by: Olemis Lang
Priority: normal Component: WhiteboardPlugin
Severity: normal Keywords:
Cc: john.tantalo@… Trac Release: 0.11

Description

The regex to match the ticket number fails for tickets > 9.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by anonymous

proposed patch:

-            "ticket": /(board_ticket_)(\d)/.exec(ui.item.attr("id"))[2],
+            "ticket": /(board_ticket_)(\d+)/.exec(ui.item.attr("id"))[2],

comment:2 Changed 6 years ago by anonymous

Cc: john.tantalo@… added; anonymous removed

comment:3 Changed 6 years ago by Poly Flor

This is a nice plugin. It might even get nicer if the people know how to report bugs effectly (ask Google). Too bad this happens too rarely...

Anyhow, the bug submitter is right with his finding. But the regex does not fail it just matches ticket-numbers from 1 to 9. However, only a few software projects have this small bug count. ;-)

The effect of the glitch in the match of the regexp is that the "save changes" does only work if you move tickets with numbers 1 to 9 around in the whiteboard.

The suggested change which fixes this issue is included in the patch for #7633. I propose to close this issue when the patch is in the mainline of the plugin.

comment:4 Changed 5 years ago by Ryan J Ollos

Owner: changed from CuriousCurmudgeon to Olemis Lang

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Olemis Lang.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.