Various improvements to MovieMacro

[Scott Gifford]

I have implemented several improvements to MovieMacro, including:

• Updating to latest version of ​flowplayer
• Support Image-macro style path arguments for local files (attachment:file.mp4, wiki:TestPage:2357b.mp4, etc.)
• Support for configuring in INI file:
  • Default height
  • Default width
  • Streaming provider
  • SWF file URL
• Support for setting in macro arguments:
  • Starting position for scrubber (startpos)
  • Clip start (implemented per Flowplayer docs, seems not to work) (stime)
  • Clip duration (duration)

[Scott Gifford]

Patch with changes described in #8807

[Scott Gifford]

Note that these also require flowplayer 3.2.7 or (hopefully) newer, currently available from:

​http://flowplayer.org/download/index.html

[Tetsuya Morimoto]

I updated flowplayer's version to 5.5.0.

​https://github.com/arielnetworks/TracMovieMacro/commit/b9dfb77f893acd46d8daced6619d4bea76d66b6c

[Tetsuya Morimoto]

I changed to set default width, height, splash image using trac.ini like this.

[moviemacro]
width = 320px
height = 180px
splash = test.png

• ​https://github.com/arielnetworks/TracMovieMacro/commit/b67f32f0cb64e0f68a00a276b5c4c52d59ec679a
• ​https://github.com/arielnetworks/TracMovieMacro/commit/4e421d15843f1df478c0d32514f85feb82645cf7

[Tetsuya Morimoto]

Replying to sgifford:

• Support Image-macro style path arguments for local files (attachment:file.mp4, wiki:TestPage:2357b.mp4, etc.)

Yup, that makes using moviemacro easy.

[Tetsuya Morimoto]

ImageMacro parses the argument by itself without utility function. I will support restricted simple format only.

​https://github.com/edgewall/trac/blob/trunk/trac/wiki/macros.py#L518

[Tetsuya Morimoto]

To support restricted ImageMacro style.

​https://github.com/arielnetworks/TracMovieMacro/commit/1740f7d7645171b79f4ab0035745357edd41eb64

​https://github.com/arielnetworks/TracMovieMacro/commit/006b73dc5170d18d20962860de3689515b916db4

[Ryan J Ollos]

If the json requirement is the only reason for the Python >= 2.6 restriction in [14231], it would be easy enough to add a fallback:

try:
    import json
except ImportError:
    import simplejson as json

and also conditionally add simplejson to requirements. For example, see: tracticketchangelogplugin/0.12/setup.py@13960:55#L37​

[Jun Omae]

The plugin supports only 2.6 and later, according to moviemacro/trunk/setup.py@14231:7-8​.

However, we can replace with to_json (trac.util.presentation) which is available since Trac 0.12. Because it seems json library is used for only encoding to json string. At least, I think we can simply use json.dumps(query_dict) rather than json.JSONEncoder().encode(query_dict).

[Tetsuya Morimoto]

Thank you for good advice. I will replace to_json if possible, then we can remove Python > 2.6 limit. Also, I misunderstood json.dumps function, you're right. :)

[Tetsuya Morimoto]

It works and increased maintainability by changeset:14232. Thank you!

[Tetsuya Morimoto]

This change has been included in 0.3 version (ticket:12046#comment:2).