Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8822 closed enhancement (wontfix)

Patch for Trac 12b1

Reported by: rlrj60 Owned by: Itamar Ostricher
Priority: normal Component: CkEditorPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The plugin is fully working on my Trac 12b1 installation. First it complained "file not found" on a number of css and js. I fixed it by adding the paths to the setup.py, then rebuild the plugin. Later on more missing files when clicking on some buttons such as the smiley. End up I had to add all the directory paths to the setup.py.

Attached is patch that works fine on my Trac 12b1.

Attachments (1)

patch_for_12b1.diff (14.9 KB) - added by rlrj60 6 years ago.
Patch for Trac 12b1 installation

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by rlrj60

Attachment: patch_for_12b1.diff added

Patch for Trac 12b1 installation

comment:1 Changed 6 years ago by Itamar Ostricher

Resolution: wontfix
Status: newclosed

Thanks for the feedback!

It works for me on Trac-0.12.1 and Trac-0.12.2 (why are you using b1?) without the patch, but I'm going to close this ticket as wontfix because the next version of the plugin will adopt the approach described in #8586, in which the CKEditor module is not packaged with the plugin itself, so this will no longer be an issue.

comment:2 in reply to:  1 Changed 6 years ago by rlrj60

Yes. I should update my Trac base to 0.12.2, but didn't have a chance yet. Sounds like you have a cool plan so it's ok to close the ticket. Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Itamar Ostricher.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.