Opened 7 years ago

Closed 7 years ago

yui_base_url not honored in templates ?

Reported by: Owned by: Christian Masopust Roberto Longobardi low TestManagerForTracPlugin normal 0.12

Description

Alltough the stats.py defines an option "yui_base_url", this option is not used within the templates (testmanagerstats.html still includes scripts directly from yui.yahooapis.com).

I would prefere to have the yui local installed (as intended by adding the option in stats.py :-)) as not all of our clients always have connection to the internet...

comment:1 follow-up:  3 Changed 7 years ago by Roberto Longobardi

Hi Christian, I've cleaned this up :D In my initial copy/paste from the TracTicketStatsPlugin I didn't bother about this detail, but if it's there it must be useful right? :)

You can find in attachment a zip file with the modified versions of two files.

Replace them in the plugin source tree and rebuild.

Please, note that I have modified the options stanza name to be specified in trac.ini to "testmanager" (instead of "teststats").

For example, to set the library to the latest 2.0 release:

[testmanager]
yui_base_url = http://yui.yahooapis.com/2.9.0


Let me know if this works.

Ciao, Roberto

comment:2 Changed 7 years ago by Roberto Longobardi

(Ignore the second attachment, they're the same)

comment:3 in reply to:  1 Changed 7 years ago by Christian Masopust

Hi Christian, I've cleaned this up :D In my initial copy/paste from the TracTicketStatsPlugin I didn't bother about this detail, but if it's there it must be useful right? :)

You can find in attachment a zip file with the modified versions of two files.

Replace them in the plugin source tree and rebuild.

Please, note that I have modified the options stanza name to be specified in trac.ini to "testmanager" (instead of "teststats").

For example, to set the library to the latest 2.0 release:

[testmanager]
yui_base_url = http://yui.yahooapis.com/2.9.0


Let me know if this works.

Ciao, Roberto

Hi Robert,

works perfect!!

Thanks a lot for the quick response!

Christian

comment:4 Changed 7 years ago by Roberto Longobardi

Resolution: → fixed new → closed

No problem!

Also, I'm enriching the set of charts in this test statistics page, according to this enhancement request #8875.

You'll see them pretty soon in next release 1.4.6.

If you have any comments or ideas about it, feel free to post on that ticket.

Ciao, Roberto

comment:5 Changed 7 years ago by Roberto Longobardi

Released in 1.4.6.

Modify Ticket

Change Properties
Action
as closed The owner will remain Roberto Longobardi.
The resolution will be deleted.