Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8968 closed defect (fixed)

major heading error on day view

Reported by: Patrick Schaaf Owned by: Chris Nelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

When using dateDisplay = yyyy-mm-dd (instead of the default), major headings read undefined - 2011-7-9 and also wrap to two lines.

That wrap to two lines, results in the whole right pane (chart area) being shifted down by half a row height, wrt. the left pane (summary, resource, etc).

See the attached picture for details.

Attachments (3)

trac-jsgantt-undefined-date-heading.png (25.4 KB) - added by Patrick Schaaf 6 years ago.
r10479.png (41.8 KB) - added by Ryan J Ollos 6 years ago.
r10480.png (19.8 KB) - added by Ryan J Ollos 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by Patrick Schaaf

comment:1 Changed 6 years ago by Patrick Schaaf

Problem happens with both trac 0.11.6 and trac 0.12.2.

On my 0.12.2 test install I also reverted all the changes I made yesterday, the problem remains then same with the plugin out of the current SVN.

Using the default date format I also see an example where 7/10 - 7/16/2011 is displayed (no undefined), and also wraps to two lines, with the same half-row shift between left and right panes as a result.

comment:2 Changed 6 years ago by Ryan J Ollos

I'm planning to do some work on improving the date handling this weekend, along with #8988. I can take a look at this ticket if it's still open, assuming it's an issue in Python and not JavaScript.

comment:3 in reply to:  2 Changed 6 years ago by Patrick Schaaf

Replying to rjollos:

I'm planning to do some work on improving the date handling this weekend, along with #8988. I can take a look at this ticket if it's still open, assuming it's an issue in Python and not JavaScript.

It is purely in JavaScript. The python code passes dates regarding the individual rows to the JS, which then calculates all these headings.

comment:4 Changed 6 years ago by Chris Nelson

Status: newassigned

We are almost done with a fix to this. I hope to push the patch this week.

comment:5 Changed 6 years ago by Chris Nelson

(In [10480]) Changed major date header to display month year. Refs #8968.

comment:6 Changed 6 years ago by Chris Nelson

Resolution: fixed
Status: assignedclosed

Changed 6 years ago by Ryan J Ollos

Attachment: r10479.png added

Changed 6 years ago by Ryan J Ollos

Attachment: r10480.png added

comment:7 Changed 6 years ago by Ryan J Ollos

My macro call doesn't specify dateDisplay. When upgrading from r10479 to r10480, the default headings changes.

From:

To:

I'm happy with either format, but thought I'd mention here to confirm that this was the intended change when dateDisplay isn't specified as a macro argument.

comment:8 in reply to:  7 Changed 6 years ago by Chris Nelson

Replying to rjollos:

My macro call doesn't specify dateDisplay. When upgrading from r10479 to r10480, the default headings changes. ... I'm happy with either format, but thought I'd mention here to confirm that this was the intended change when dateDisplay isn't specified as a macro argument.

dateDisplay no longer applies to week labels in day view. This allows a more compact display that won't wrap.

comment:9 Changed 6 years ago by anonymous

Upgraded to r10480 without problems, on both 0.11.7 and 0.12.2

I like the new major heading very much - the clear text month name is much more informative!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Chris Nelson.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.