#8968 closed defect (fixed)
major heading error on day view
Reported by: | Patrick Schaaf | Owned by: | Chris Nelson |
---|---|---|---|
Priority: | normal | Component: | TracJsGanttPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
When using dateDisplay = yyyy-mm-dd (instead of the default), major headings read
undefined - 2011-7-9
and also wrap to two lines.
That wrap to two lines, results in the whole right pane (chart area) being shifted down by half a row height, wrt. the left pane (summary, resource, etc).
See the attached picture for details.
Attachments (3)
Change History (12)
Changed 13 years ago by
Attachment: | trac-jsgantt-undefined-date-heading.png added |
---|
comment:1 Changed 13 years ago by
comment:2 follow-up: 3 Changed 13 years ago by
I'm planning to do some work on improving the date handling this weekend, along with #8988. I can take a look at this ticket if it's still open, assuming it's an issue in Python and not JavaScript.
comment:3 Changed 13 years ago by
Replying to rjollos:
I'm planning to do some work on improving the date handling this weekend, along with #8988. I can take a look at this ticket if it's still open, assuming it's an issue in Python and not JavaScript.
It is purely in JavaScript. The python code passes dates regarding the individual rows to the JS, which then calculates all these headings.
comment:4 Changed 13 years ago by
Status: | new → assigned |
---|
We are almost done with a fix to this. I hope to push the patch this week.
comment:5 Changed 13 years ago by
comment:6 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Changed 13 years ago by
Attachment: | r10479.png added |
---|
Changed 13 years ago by
Attachment: | r10480.png added |
---|
comment:7 follow-up: 8 Changed 13 years ago by
comment:8 Changed 13 years ago by
Replying to rjollos:
My macro call doesn't specify
dateDisplay
. When upgrading from r10479 to r10480, the default headings changes. ... I'm happy with either format, but thought I'd mention here to confirm that this was the intended change whendateDisplay
isn't specified as a macro argument.
dateDisplay
no longer applies to week labels in day view. This allows a more compact display that won't wrap.
comment:9 Changed 13 years ago by
Upgraded to r10480 without problems, on both 0.11.7 and 0.12.2
I like the new major heading very much - the clear text month name is much more informative!
Problem happens with both trac 0.11.6 and trac 0.12.2.
On my 0.12.2 test install I also reverted all the changes I made yesterday, the problem remains then same with the plugin out of the current SVN.
Using the default date format I also see an example where
7/10 - 7/16/2011
is displayed (noundefined
), and also wraps to two lines, with the same half-row shift between left and right panes as a result.