Modify

Opened 6 years ago

Last modified 4 years ago

#9020 new defect

RecapthaRegisterPlugin don't want to work with new versions of Accountmanager

Reported by: Sagrer Owned by: Alejandro J. Cura
Priority: high Component: RecaptchaRegisterPlugin
Severity: normal Keywords: template
Cc: Ryan J Ollos, Pedro Algarvio, aka, s0undt3ch Trac Release: 0.12

Description (last modified by Steffen Hoffmann)

#8925 - this ticket describes some changes in accountmanager - it was a bug in it (which was fixed) because "r10288 in AccountManagerPlugin (trunk) changed the server's parameter from "user" to "username"" - so, now RecaptchaRegisterPlugin has the same bug and works only with AccountManagerPlugin r10287 and lower/

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added; anonymous removed
Keywords: template added

Some claims of #9608 have been shut down for raising exactly the problem reported here.

As you already pointed out, it would be good, if the author and/or current maintainer followed AccountManagerPlugin development, especially the changes, that lead to the existing diversion. A quick fix should be relatively easy and straight-forward.

OTOH I strongly advocate for a more lasting solution, that is not to include a replacement page template at all, but do modifications of the original registration form i.e. with an ITemplateStreamFilter implementation. The corresponding filter_stream() method is capable of modifying the existing template from AccountManagerPlugin on the fly. Have a look at TagsPlugin's WikiTagInterface (see browser:tagsplugin/trunk/tractags/wiki.py), that adds a an input field to wiki_edit.html of Trac core.

This approach will not only reduce code duplication, future changes in AccountManagerPlugin could be less harmful to this plugin.

comment:2 Changed 5 years ago by Steffen Hoffmann

Marked #9524 as related, because it is a side-effect of the pending field rename.

comment:3 Changed 5 years ago by Steffen Hoffmann

Cc: Pedro Algarvio, aka, s0undt3ch added
Description: modified (diff)

Right now a new IAccountRegistrationInspector interface has been published.

Please follow #874 and try to implement that inferface, because this will become the new standard for components contributing to the new-user-registration process in AcctMgr. Participants are able to provide additional registration fields, request validation checks or both with minimal effort.

The registration form template already got 2 extensible sections, 'Required' and 'Optional', where new fields will be added. So the previously suggested ITemplateStreamFilter approach, effectively hacking the hack, is neither required nor recommended anymore.

I'll publish the rewritten standard registration checks, that are built-in into AcctMgr, to give some example implementations for early adopters. If you need support for your plugin, follow-up here, please.

comment:4 Changed 4 years ago by Steffen Hoffmann

Priority: normalhigh

Improve visibility for this show-stopper issue - not working plugin with current AcctMgr.

Modify Ticket

Action
as new The owner will remain Alejandro J. Cura.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.