[PATCH] remove superflous error message about wiki_namespace

[Patrick Schaaf]

Upgrading to the current SVN trunk, I noticed today error messages

Trac[model] ERROR: DatabaseError: no such table: wiki_namespace

in my logs. svn blame model.py points to [10384], where that logging was added.

As far as I can see, that wiki_namespace table is not supposed to exist, and it surely does not exist in my setup. The _need_migration function's try block attempts to access the table for the sole purpose to note its existance - with the except: path being the expected outcome on newer versions not needing migration. Or, at least, that's how the whole thing looks to me...

Appended patch just removes that error message output.

[Patrick Schaaf]

remove wiki_namespace error message

[Steffen Hoffmann]

Confirm, this is how it looks like to me too.

I've obviously overlook that situation when changes a lot of exception handlers in the aforementioned changeset. Thanks for taking care.

[Steffen Hoffmann]

(In [10498]) TagsPlugin: Remove a superflous error message, closes #9023.

Thanks to bof for reporting the situation and suggesting the fix.

[Steffen Hoffmann]

BTW, adding yourself to Cc in #9022 would have been preferred over creating another ticket (this one). And users like rjollos or otaku42 are certainly able and willing to correct such ticket properties for you, if only you're asking kindly at the mailing-list (th-users). Just my 2 cents.

[anonymous]

Replying to hasienda:

BTW, adding yourself to Cc in #9022 would have been preferred over creating another ticket (this one).

Actually, I only realized that the "anonymous" ticket was already created, after I made the other ticket.

I started ticket creation, entered the description, checked "I have attachments", and submitted. Then, on the attachment upload page, I saw that I wasn't logged in, and pressed the login link at the top of the page. Somehow (I'm not absolutely sure what I did then) I was back on the ticket submission page itself, logged in, but with an empty description. I used the back button to go to the previous page where I was anonymous, cut&pasted the description that was there, went forward again, and submitted.

It was only 10 minutes later when looking at the timeline, that I noticed the ticket was now created twice.

I wish trac would, when I select "I have attachments", only create the ticket once I have the attachment properly uploaded...

[Steffen Hoffmann]

Thanks for the explanation, so now I understand. Never mind, rally, it caused no problem at all. Only I wasn't aware of such a Trac trap.

[anonymous]

This still isn't fixed in ​svn, despite the commit message - why is this ticket closed?

[anonymous]

You commented out the wrong line in r10498 - it should be line 46, not 77.

[Steffen Hoffmann]

Replying to anonymous:

This still isn't fixed in ​svn, despite the commit message - why is this ticket closed?

My fault, sorry, not meant to fool someone. But I've obviously take the error for the upgrade procedure, not the check.

[Steffen Hoffmann]

Replying to anonymous:

You commented out the wrong line in r10498 - it should be line 46, not 77.

True, thanks. Will revert r10498 and do it correctly this time.

[Steffen Hoffmann]

(In [10628]) TagsPlugin: Revert changeset [10498] and apply the correct fix, closes #9023 - this time for real.

Remove a superflous error message on Trac environment startup. Must have been simply to much distracting my eyes. I didn't see this despite of regular own tests. Thanks for nudging me.

[ogiesen]

I'm getting that exact error message when trying to upgrade my environment after upgrading from trac 0.11.7 to 1.0.1 and as far as I can tell the upgrade fails for that reason. Is this still the same issue (all the Google hits for that message lead here)?

My TagsPlugin was already on 0.6 . Any ideas? I'm using Python 2.7.5 on Windows Server 2003 with Apache 2.2.9 and WSGI 2.5.2.

Update: Nevermind. I didn't realize 0.6 preceded this fix, seeing that it was already 2 years old... When using TagsPlugin from the /trunk it works fine.

[Steffen Hoffmann]

Replying to ogiesen:

Nevermind. I didn't realize 0.6 preceded this fix, seeing that it was already 2 years old... When using TagsPlugin from the /trunk it works fine.

I don't mind, but I do care, so its always good to get a fix positively confirmed. To be true, meanwhile there has been much more about that upgrade code, see #9521 for details.