Modify

Opened 13 years ago

Last modified 12 years ago

#9050 new defect

problem with warning info and trac theme

Reported by: anonymous Owned by: Carlos Jenkins Pérez
Priority: high Component: TseveTheme
Severity: major Keywords: warning info
Cc: Trac Release: 0.12

Description

Hello,

I use trac 0.12 with TseveTheme (i have test Crystal and Skittlish it's the same) and i have 2 problems with that. With default theme, when i want create a ticket without summary i can't but with a theme i can. And when i want modify a ticket without summary, a message say to look at the top but no message info. (look my screenshot for understand i think)

Attachments (3)

theme_problem.PNG (30.8 KB) - added by anonymous 13 years ago.
no_problem_without_theme.PNG (29.4 KB) - added by anonymous 13 years ago.
cowboy-55-1024.jpg (99.6 KB) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by anonymous

Attachment: theme_problem.PNG added

Changed 13 years ago by anonymous

Changed 13 years ago by anonymous

Attachment: cowboy-55-1024.jpg added

comment:1 Changed 12 years ago by anonymous

Priority: normalhigh
Severity: normalmajor

Any progress on this? It's kind of an annoying issue.

comment:2 Changed 12 years ago by Chris Bush

After playing around with the template/css, I've got it working. I've uploaded both files as a quick fix, for anyone who's still interested.

comment:3 Changed 12 years ago by Chris Bush

Or not. Didn't realize you can't upload html files to TH. I guess if you want the patch, email me.

comment:4 in reply to:  3 Changed 12 years ago by Ryan J Ollos

Replying to cjbush77@gmail.com:

Or not. Didn't realize you can't upload html files to TH. I guess if you want the patch, email me.

Yes, there are some problems in that area, see #7539. As a workaround, we usually compress the file (zip, tar, etc.) or paste the patch as a ticket comment, in a WikiProcessor:

{{{
#!patch

}}}

comment:5 Changed 12 years ago by anonymous

My bad, you're right. Obviously I'm new to Trac Hacks. Should I go ahead and close the ticket as well, or leave that for the plugin author?

Here's the patch:

In tsevetheme\0.11\tsevetheme\templates\tseve_theme.html

  • 0.11/tsevetheme/htdocs/tseve.css

     
    5353        text-decoration: underline;
    5454}
    5555
     56#system {
     57    background: white;
     58    border-left: 1px solid white;
     59    border-right: 1px solid white;
     60    clear: both;
     61    padding: 1px 10px;
     62}
     63
    5664#custom-mainnav {
    5765    float: right;
    5866    margin-right: 30px;
  • 0.11/tsevetheme/templates/tseve_theme.html

     
    5858   
    5959        <!-- Main content -->
    6060        <div id="main-content">
    61 
     61           
     62            <div id="system">
     63                <div id="warning" py:if="chrome.warnings" class="system-message">
     64                    <py:choose test="len(chrome.warnings)">
     65                        <strong>Warning:</strong>
     66                        <py:when test="1">${chrome.warnings[0]}</py:when>
     67                        <py:otherwise><ul><li py:for="warning in chrome.warnings">$warning</li></ul></py:otherwise>
     68                    </py:choose>
     69                </div>
     70                <div id="notice" py:if="chrome.notices" class="system-message">
     71                    <py:choose test="len(chrome.notices)">
     72                        <py:when test="1">${chrome.notices[0]}</py:when>
     73                        <py:otherwise><ul><li py:for="notice in chrome.notices">$notice</li></ul></py:otherwise>
     74                    </py:choose>
     75                </div>
     76            </div>
     77           
    6278            <!-- Contextnav (Start Page, Index, History, Last Change, etc) -->
    6379            <div id="custom-contextnav" class="custom-nav">
    6480                <!-- <ul py:if="chrome.ctxtnav"> -->

comment:6 in reply to:  5 Changed 12 years ago by anonymous

Replying to anonymous:

My bad, you're right. Obviously I'm new to Trac Hacks. Should I go ahead and close the ticket as well, or leave that for the plugin author?

We like to leave the tickets open until the patches get incorporated. I don't see any activity on the plugin since 2010. If the author approves, or if there is no response for two weeks (per the policy in AdoptingHacks), I can get this pushed to the core. If the author is not around, and you are particularly enthusiastic about the plugin, you could even take over maintenance ;)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Carlos Jenkins Pérez.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.