Opened 7 years ago

Closed 6 years ago

#9139 closed defect (fixed)

Reported by: Owned by: Nibbler Steffen Hoffmann normal AccountManagerPlugin normal casing 0.12

Description

SvnServePasswordStore uses Configuration to read the passwd file which forces the usernames to lower case. This is not desirable if you wish to use usernames that are not all lower case.

TracAccountManager 0.3.2

comment:1 Changed 7 years ago by Steffen Hoffmann

The fix is certainly valid, regarding this StackOverflow answer.

But do you really only want to adjust casing for the file specified in trac.ini, not for the one hinted in svnserve.conf? At least this is what I read from your proposed patch.

comment:2 Changed 7 years ago by Steffen Hoffmann

As a side-note: I fear, there are even more shortcomings with this part. From reading the code I suspect, that it is not yet ready for the multi-repos support in Trac 0.12, but I've no use for software development here, so no repository for immediate testing.

comment:3 follow-up:  4 Changed 7 years ago by Nibbler

But do you really only want to adjust casing for the file specified in trac.ini, not for the one hinted in svnserve.conf? At least this is what I read from your proposed patch.

It's not clear from the context of the patch but the fix applies to both cases.

You are probably right about multi-repos support, we don't use it.

comment:4 in reply to:  3 Changed 7 years ago by Steffen Hoffmann

Status: new → assigned

It's not clear from the context of the patch but the fix applies to both cases.

Ok, I'll take your word for this and require positive feedback after changeset to include it into the next official release (tags-0.7).

You are probably right about multi-repos support, we don't use it.

Nevermind. Many more things to take care, before this could get into focus.

comment:5 Changed 7 years ago by Steffen Hoffmann

(In [10630]) AccountManagerPlugin: Preserve case of user names in SvnServePasswordStore, refs #9139.

Thanks to Nibbler for report as well as the suggested fix.

comment:6 Changed 6 years ago by Steffen Hoffmann

Resolution: → fixed assigned → closed

(In [12398]) AccountManagerPlugin: Releasing version 0.4, pushing development to acct_mgr-0.5dev.

Availability of that code as stable release closes #874, #3459, #4677, #5295, #5691, #6616, #7577, #8076, #8685, #8770, #8791, #8990, #9052, #9079, #9090, #9139, #9246, #9252, #9547, #9618, #9676, #9843, #9852, #9940, #10023, #10028, #10123, #10142, #10204, #10276, #10397, #10412, #10594, #10625 and #10644.

Some more issues have been worked-on, yet without confirmed resolution, refs #5464 (for JiraToTracIntegration), #8927 and #10134.

And finally there are some issues and enhancement requests showing progress, but known to require more work to resolve them satisfactorily, refs #843, #1600, #5964, #8217, #8933.

Thanks to all contributors and followers, that enabled and encouraged a good portion of this development work.

Modify Ticket

Change Properties