Modify

Opened 15 months ago

Last modified 14 months ago

#11179 assigned defect

[Patch] Milestones on versions page are not shown in 0.12/trunk & /versions not working

Reported by: AlexK Owned by: rjollos
Priority: highest Component: ExtendedVersionPlugin
Severity: major Keywords:
Cc: Trac Release: 1.0

Description

When the patch I wrote was applied 2 years ago, the whole "show milestones underneath each version" feature was only applied to the 0.11 folder but not 0.12. Therefore this feature is no longer part of trunk!

Attachments (3)

roadmap.diff (10.2 KB) - added by AlexK 15 months ago.
Fixes roadmap version view and regex bug
roadmap.2.diff (10.1 KB) - added by AlexK 15 months ago.
Corrected version
roadmap.3.diff (10.4 KB) - added by AlexK 15 months ago.
Previous patch plus removed ul/li marker in roadmap view

Download all attachments as: .zip

Change History (10)

comment:1 Changed 15 months ago by rjollos

Are you referring to [10468] / #7620?

Changed 15 months ago by AlexK

Fixes roadmap version view and regex bug

comment:2 follow-up: Changed 15 months ago by AlexK

  • Priority changed from high to highest
  • Summary changed from Milestones on versions page are not shown in 0.12/trunk to [Patch] Milestones on versions page are not shown in 0.12/trunk & /versions not working

Patch fixes milestones to be available in version view again, adapted for trac 1.0 CSS style. Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

comment:3 Changed 15 months ago by anonymous

Oops, had a bug due to incorrect indention in the first version of the patch.

Changed 15 months ago by AlexK

Corrected version

Changed 15 months ago by AlexK

Previous patch plus removed ul/li marker in roadmap view

comment:4 Changed 15 months ago by rjollos

  • Status changed from new to assigned

I probably won't get to this for a few days, but it's in my near-term work plan.

comment:5 in reply to: ↑ 2 Changed 14 months ago by rjollos

Replying to AlexK:

Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

I haven't successfully reproduced the infinite recursion issue, however I confirm that the regex doesn't work as intended. I setup some tests and modified the regex. The previous commit that caused the issue was [12231].

As for the rest of the changes, they'll take me a while to sort through. If you were to break up this up into a series of patches representing concise changes, that would speed up the process.

comment:6 Changed 14 months ago by rjollos

In 13341:

Added unit test harness and failing unit test for VisibleVersion.match_request. Refs #11179.

comment:7 Changed 14 months ago by rjollos

In 13342:

Fixed regression from [12231]. Refs #10354, #11179.

VisibleVersion.match_request should not return True for the path /versions.

Add Comment

Modify Ticket

Action
as assigned .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.