OpenID return_to generation broken when req.href() is empty

[cygnus@…]

When req.href() is empty, the slice used to build the return_to and trust_root URLs for OpenID results in an empty return_to base URL, which causes OpenID to fail. The attached patch applies the slice only if len(req.href()) > 0.

[cygnus@…]

Patch to fix return_to and trust_root generation

[wkornewald]

Thanks for the patch. I've applied it, now.

Would you be interested in taking this plugin over?

After having played with OpenID and thought about it again, I think it doesn't work the way I want (too much dependence on the provider). I prefer CardSpace because it can be used for critical authentication whereas I would never trust OpenID for accessing my bank account or even my emails, for example.

[lazaridis_com]

readded CC

[cygnus@…]

Yeah, I'm interested in taking it over. (ilias@…: turns out I get CC'd as owner, but thanks for fixing the CC anyway.)

[wkornewald]

Then, just register an account, tell me your username, and I'll contact Alec Thomas to give you svn access (or you can do it).

[cygnus]

Thanks! I've sent him an email and await SVN access.

[lazaridis_com]

you may want to take a look at ​this thread and this ticket: ​trac:#2456

[Alec Thomas]

Okay I've provided write permissions to cygnus.