Modify ↓

Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#10858 closed defect (fixed)

Template isn't loaded for NewTicket in Trac 1.0

Reported by: Rochi Owned by: Richard Liao
Priority: normal Component: TracTicketTemplatePlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

Depends on Trac 1.0.x

If you create a new ticket in Trac 1.0 tickettemplate doesn't load the template. You have first to switch the ticket type to throw a change event.

The problem is located in line 338 in tt_newticket.js:

if ($("#ticket.ticketdraft").length && isLoad) {
                // reset isLoad
                isLoad = false;
                return;
            }

you have to change it to:

if ($("#ticket.ticketdraft").css('display') != 'none' && isLoad) {
                // reset isLoad
                isLoad = false;
                return;
            }

Maybe you have to modify my patch to support Trac 0.12 and Trac 1.0

Attachments (0)

Change History (8)

comment:1 Changed 13 years ago by Rochi

Maybe this is fixed in [13260]?

Last edited 13 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 13 years ago by Ryan J Ollos

Resolution: → fixed
Status: new → closed

It is fixed per the testing I've done.

comment:3 Changed 13 years ago by Ryan J Ollos

Is it okay if I bump the version to 0.8? Keeping it at 0.7 for so long is ​causing confusion. It would also be useful to modify the setup.cfg file to append the SVN revision to the egg, like the one here​ (though I see that's been commented out in your setup.cfg).

Last edited 13 years ago by Ryan J Ollos (previous) (diff)

comment:4 Changed 13 years ago by Ryan J Ollos

It would also be good to make this change as a preventive measure, to avoid conflicts:

-$(document).ready(function() {
-    $("body").tt_newticket();
-});
+jQuery(document).ready(function($) {
+    $("body").tt_newticket();
+});

comment:5 Changed 13 years ago by Ryan J Ollos

In 13633:

0.8: Bump version to 0.8. Added SVN revision to egg. Refs #6589, #6809, #7311, #7404, #7440, #8555, #8609, #9238, #10858.

comment:6 Changed 13 years ago by Rochi

Thx,

I will test it in a few days.

comment:7 in reply to:  3 Changed 13 years ago by Russell Ballestrini

Replying to rjollos:

Is it okay if I bump the version to 0.8? Keeping it at 0.7 for so long is ​causing confusion. It would also be useful to modify the setup.cfg file to append the SVN revision to the egg, like the one here​ (though I see that's been commented out in your setup.cfg).

Yeah tag_svn_revision = true was commented out in setup.cfg accidentally an is a mistake. It occurred on this change: [1334]

Last edited 13 years ago by Ryan J Ollos (previous) (diff)

comment:8 in reply to:  4 Changed 13 years ago by Ryan J Ollos

Replying to rjollos:

It would also be good to make this change as a preventive measure, to avoid conflicts:

Fixed in [13725].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Richard Liao.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.