Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10932 closed defect (fixed)

undefined variable en in line 279

Reported by: darth Dingleberry Owned by: branson
Priority: normal Component: DirectoryAuthPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (last modified by Ryan J Ollos)

Hi, First off thanks for keeping this critical plugin moving along ;-) Now my little typo find: I think this should be "e" not "en" as that makes it put out a proper error message.

Line is the raise statement:

    self._ldap.simple_bind_s(self.dir_binddn, self.dir_bindpw)
except ldap.LDAPError, e:'bind_ad: binding failed. %s ' % (e))
    raise TracError('cannot bind to %s: %s' % (self.dir_uri , en))

Also I would like to work on getting memberOf working as we need that functionality in order to use this tool. How would I go about making that level of contribution? I have another python tool that does most of the work already in place. Lastly we have to force referrals off to make this work, currently that means locally forked code. I would like to get that worked in as well to trunk.

Thanks, Eddie J

ps apologies for the email mixed with a bug report, not sure how to get into the "loop"

Attachments (0)

Change History (10)

comment:1 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 5 years ago by lkraav

Yeah, confirming the typo part. It's a rather low cost patch, I wonder if sandinak could push it to the repo with some urgency? Is he still interested in the plugin?

comment:3 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:4 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

(In [12713]) Fixes #10932: Fixed typo in passing exception object to TracError.

comment:5 in reply to:  2 Changed 5 years ago by Ryan J Ollos

Replying to lkraav:

Is he still interested in the plugin?

To speak to darth_dingleberry's earlier question, if sandinak isn't around any longer, you can request to take over maintenance of the plugin; see AdoptingHacks. However, I think sandinak is around, so hopefully we hear back shortly.

comment:6 Changed 5 years ago by darth Dingleberry

rjollos thanks for the quick fix. I will wait for sandinak to reply and keep working on my local copy. I would like to earn commit privs after putting up a few patches.

thanks Eddie

comment:7 Changed 5 years ago by branson

so I am around .. just havn't had the bw to contribute to this recently .. I'm building a trac-1.0.1 release today for other stuff .. and will test the plugin and go thru the open issues. Sorry for the delay.. been busy as crap with 10000 other things.

comment:8 Changed 5 years ago by lkraav

I have been running this on top of current 1.1.1-dev trunk, it's working without issues.

But there's definitely stuff to do and improve on. Trying to find that patching time somewhere myself.. Stay tuned for some additional tickets :)

comment:9 Changed 5 years ago by darth Dingleberry

lkraav would you like to PM about what your thoughts are on expanding this plugin?

My first and foremost is gettting memberOf working for us so we can use this natively and get rid of all the Apache baggage.

Also a few others that would be nice to try and get handled if we can together work up some bandwidth. And of course whatever sandinak has cooking.

Thanks dD

comment:10 Changed 5 years ago by lkraav

I think it would make sense to kick off a public discussion thread in trac-dev mailing list instead, or just straight file feature tickets right here.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain branson.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.