New user and hacks pages should be passed through the spam filter

[Ryan J Ollos]

I have looked into this myself so I'm fuzzy on the details, but stoecker mentioned over email that the new user pages aren't passing through the SpamFilter. I have to assume that the same is true for NewHack pages.

[Ryan J Ollos]

See also #11742.

[Dirk Stöcker]

Creating a Adapter for NewHacks is easy. Simply call

FilterSystem(self.env).test(req, author, changes)

where author is an author name and changes a list of before/after strings. For NewHack the before is probably always None.

Examples:

• ​browser:plugins/1.0/spam-filter/tracspamfilter/adapters.py
• ​browser:plugins/1.0/spam-filter/tracspamfilter/accountadapter.py

See examples how to extract author name.

Best is to encapsulate the code, so that it only is called when spam-filter exists.

[Ryan J Ollos]

In 16630:

TracHacks 3.0.5: Put database transaction in a context manager

Remove code for rolling back transaction. The database
transaction are now atomic, and if those succeed there is
not much that can go wrong in adding the repository
path and the ACL entry.

Refs #11200.

[Ryan J Ollos]

In 16632:

TracHacks 3.0.5: Pass new hacks through the spam filter

• Use of SpamFilter is still optional
• Remove test code and unintentional change from r16630

Fixes #11200.

[Ryan J Ollos]

Tested deployment in r16633, r16634.