Modify

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12480 closed defect (fixed)

Trac 1.2 incompatibility

Reported by: sdegrande Owned by: sdegrande
Priority: normal Component: TracWikiPrintPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release: 1.2

Description

Please find attached a quick patch to have this plugin work with Trac 1.2 (python 2.7)

Thanks for your work.

Attachments (1)

fix_1.2_compat.diff (2.4 KB) - added by sdegrande 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by sdegrande

Attachment: fix_1.2_compat.diff added

comment:1 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 14874:

2.0.0dev: Use Trac 1.0 database API. Fixes #12480.

Patch by sdegrande.

comment:2 Changed 4 years ago by Ryan J Ollos

Owner: changed from Álvaro Iradier to sdegrande

Thanks for the patch. I refactored the database queries and transactions to conform to the Trac style. Would you be able to do some additional testing on the 1.0 branch to confirm the fix?

comment:3 Changed 4 years ago by sdegrande

Works for me. The ticket can be closed. Thx.

And thanks for the example on how you want to use the DB API. Once I'm done with our site upgrade, I'll try to find some more time to update the other patches that I sent.

Note: Just to let you know, several files are in DOS format (with CRLF)... I don't know what is your rule about them...

comment:4 in reply to:  3 Changed 4 years ago by Ryan J Ollos

Replying to sdegrande:

And thanks for the example on how you want to use the DB API. Once I'm done with our site upgrade, I'll try to find some more time to update the other patches that I sent.

Thanks, I look forward to it!

Note: Just to let you know, several files are in DOS format (with CRLF)... I don't know what is your rule about them...

I haven't seen any problems so far.

comment:5 Changed 3 years ago by Ryan J Ollos

#13014 closed as a duplicate.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain sdegrande.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.