#12480 closed defect (fixed)
Trac 1.2 incompatibility
| Reported by: | sdegrande | Owned by: | sdegrande |
|---|---|---|---|
| Priority: | normal | Component: | TracWikiPrintPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Ryan J Ollos | Trac Release: | 1.2 |
Description
Please find attached a quick patch to have this plugin work with Trac 1.2 (python 2.7)
Thanks for your work.
Attachments (1)
Change History (6)
Changed 9 years ago by
| Attachment: | fix_1.2_compat.diff added |
|---|
comment:1 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 9 years ago by
| Owner: | changed from Álvaro Iradier to sdegrande |
|---|
Thanks for the patch. I refactored the database queries and transactions to conform to the Trac style. Would you be able to do some additional testing on the 1.0 branch to confirm the fix?
comment:3 follow-up: 4 Changed 9 years ago by
Works for me. The ticket can be closed. Thx.
And thanks for the example on how you want to use the DB API. Once I'm done with our site upgrade, I'll try to find some more time to update the other patches that I sent.
Note: Just to let you know, several files are in DOS format (with CRLF)... I don't know what is your rule about them...
comment:4 Changed 9 years ago by
Replying to sdegrande:
And thanks for the example on how you want to use the DB API. Once I'm done with our site upgrade, I'll try to find some more time to update the other patches that I sent.
Thanks, I look forward to it!
Note: Just to let you know, several files are in DOS format (with CRLF)... I don't know what is your rule about them...
I haven't seen any problems so far.
In 14874: