Modify ↓

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#12529 closed enhancement (fixed)

Update for trac 1.0 and configurable output filter

Reported by: jaroslav.benkovsky@… Owned by: jaroslav.benkovsky@…
Priority: normal Component: DiaVisViewPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Attached is a patch that:

  • makes this plugin work with Trac 1.0
  • allow Dia's output filter to be set in trac.ini. This was primarily meant to utilize png-libart instead of the ugly cairo renderer, but can be used to get SVG output requested in #9651
  • supporting options for non-png renders
  • some refactoring to split a long method somewhat
  • fix the output html element being <p> instead <a>
  • move RE compilation out of the macro expansion
  • do not check width if not needed

If the patch is too long to be accepted, I will split it to logical parts, but this Works For Me (tm)

Attachments (1)

trac10.diff​ (15.5 KB) - added by anonymous 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by anonymous

Attachment: trac10.diff​ added

comment:1 Changed 9 years ago by Ryan J Ollos

#9651 closed as a duplicate.

comment:2 Changed 9 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: new → accepted

Thanks for the patch. I'll try to get it committed soon.

comment:3 Changed 9 years ago by Ryan J Ollos

In 14915:

0.2dev: Branch for Trac 1.0 support.

Refs #12529.

comment:4 Changed 9 years ago by Ryan J Ollos

In 14916:

0.2dev: Tag build as dev.

Refs #12529.

comment:5 Changed 8 years ago by Ryan J Ollos

In 15900:

0.3dev: Make compatible with Trac 1.0

  • Use Pillow rather than PIL
  • Add Pillow to install requirements
  • Make path to Dia binary configurable from trac.ini
  • Allow Dia's output filter to be set in trac.ini
  • Support options for non-png renders
  • Refactor to split a long method somewhat
  • Fix the output html element being <p> instead <a>
  • Move RE compilation out of the macro expansion
  • Do not check width if not needed

Most of the changes provided by jaroslav.benkovsky@…

Refs #12529.

comment:6 Changed 8 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

comment:7 Changed 8 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to jaroslav.benkovsky@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jaroslav.benkovsky@….
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.