Modify ↓
Opened 9 years ago
Closed 9 years ago
#12657 closed defect (fixed)
It is possible to add comments to a closed review
Reported by: | Cinc-th | Owned by: | Olemis Lang |
---|---|---|---|
Priority: | normal | Component: | PeerReviewPlugin |
Severity: | normal | Keywords: | |
Cc: | Ryan J Ollos | Trac Release: | 0.12 |
Description
After closing a review one may still add comments to files. This should be blocked.
Attachments (0)
Change History (6)
comment:1 Changed 9 years ago by
comment:5 Changed 9 years ago by
During followup reviews it's still possible to seemingly add comments to the source review if that one is closed.
- Existing comments can be viewed and the dialog still shows the add button.
- The workaround of [15208] still prevents the actual creation of the comment.
Note: See
TracTickets for help on using
tickets.
[15208] added a workaround to prevent new comments for closed reviews. The comment subsystem will be rewritten in the future. When done a proper handling for closed reviews will be added.