Modify ↓

Opened 8 years ago

Closed 8 years ago

#12657 closed defect (fixed)

It is possible to add comments to a closed review

Reported by: Cinc-th Owned by: Olemis Lang
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release: 0.12

Description

After closing a review one may still add comments to files. This should be blocked.

Attachments (0)

Change History (6)

comment:1 Changed 8 years ago by Cinc-th

[15208] added a workaround to prevent new comments for closed reviews. The comment subsystem will be rewritten in the future. When done a proper handling for closed reviews will be added.

comment:2 Changed 8 years ago by Cinc-th

In 15244:

Don't provide Add comment links in file preview if review is closed. Does not apply to followup reviews with file previews showing differences.

Refs #12657

comment:3 Changed 8 years ago by Cinc-th

In 15246:

Don't provide Add comment links in file preview of followup reviews with file previews showing differences.

Refs #12657

comment:4 Changed 8 years ago by Cinc-th

In 15253:

  • Use jQuery UI for view comment dialog
  • Expand/collapse for replies rewritten with jQuery
  • Hide reply link for closed reviews
  • Hide Add comment button for closed reviews

Refs #12657

comment:5 Changed 8 years ago by Cinc-th

During followup reviews it's still possible to seemingly add comments to the source review if that one is closed.

  • Existing comments can be viewed and the dialog still shows the add button.
  • The workaround of [15208] still prevents the actual creation of the comment.
Last edited 8 years ago by Cinc-th (previous) (diff)

comment:6 Changed 8 years ago by Cinc-th

Resolution: → fixed
Status: new → closed

In 15254:

Hide Add Comment button for closed review (source review) even during follow up reviews.

Fixes #12657

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Olemis Lang.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.