Invalid format string

[anonymous]

I get the following error:

Error: Macro Movie(LarmaAv.webm) failed
Invalid format string

Trying to play an attachment to a wiki with

[[Movie(LarmaAv.webm)]]

[Ryan J Ollos]

I can't reproduce. If you wish to continue debugging, please make sure you have the latest version of the plugin installed, provide your Trac version and ​check the logs.

[anonymous]

This bug is caused by L161 of movie.py

The usage of strftime("%s") is platform dependent and seems to not work on windows.

Python doesn't actually support %s as an argument to strftime (if you check at ​http://docs.python.org/library/datetime.html#strftime-and-strptime-behavior it's not in the list), the only reason it's working is because Python is passing the information to your system's strftime, which uses your local timezone.

[Jun Omae]

You're right. Are you running Trac with the plugin on Windows? datetime.strftime() with %s doesn't work on Windows.

Another issue, resolution of datetime.now() is 0.010s through 0.016s on Windows. If the Movie macro is used more than once at a time, the same id might be generated by _generate_player_id on Windows.

Could you please try the following patch?

moviemacro/trunk/movie/macro.py

@@ -5 +5 @@
     Embeds various online movies.
 """
 import mimetypes
-from datetime import datetime
 from os.path import join as pathjoin
 from urlparse import urlparse
 
@@ -13 +12 @@
 from trac.core import TracError
 from trac.core import implements
 from trac.resource import Resource, get_resource_url
+from trac.util import hex_entropy
 from trac.util.html import html as tag
 from trac.util.presentation import to_json
 from trac.web.api import IRequestFilter
@@ -157 +157 @@
     # Private methods
 
     def _generate_player_id(self):
-        now = datetime.now()
-        return 'player-%s-%s' % (now.strftime('%s'), now.microsecond)
+        return 'player-' + hex_entropy()
 
     def _get_absolute_url(self, req, url):
         """ Generate an absolute url from the url with the special schemes

[Jun Omae]

Proposed patch is t12797.diff​. Unit tests pass with Trac 0.12, 1.0 and 1.2 on both Linux and Windows.

[Jun Omae]

I noticed another issue, the macro is used backslash characters to create URL on Windows. The proposed patch is including for the issue.

[Jun Omae]

In 16691:

TracMovieMacro 0.3: fix movie macro not working on Windows (closes #12797)