Xmail filter did not execute

[ntmlod]

On our Trac 1.0.1, I ran into a first issue during installation

2017-07-31 21:21:06,196 Trac[loader] ERROR: Skipping "xmail = xmail": 
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/trac/loader.py", line 68, in _load_eggs
    entry.load(require=True)
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2260, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "build/bdist.linux-x86_64/egg/xmail/__init__.py", line 2, in <module>
  File "build/bdist.linux-x86_64/egg/xmail/XMailEMailModule.py", line 22, in <module>
ImportError: cannot import name Locale

I followed the fix suggested by rjollos on comment:2:ticket:12580

xmail/XMailEMailModule.py

@@ -19 +19 @@
 from trac.notification import NotifyEmail
 from trac.util import translation
 from trac.util.datefmt import format_datetime
-from trac.util.translation import Locale, activate, domain_functions
+from trac.util.translation import activate, domain_functions
 from trac.web.api import ITemplateStreamFilter
+from trac.prefs.web_ui import Locale
 from xmail.XMailFilterObject import FilterObject
 from trac.core import Component, implements
 

Then everything seemed to go well, for testing I configured a first filter, checked the tickets list, activated it and set the execution for few minutes later but nothing happened even in the log. On Xmail page, lastsuccessexe is !void.

The date format used by Xmail MM/DD/YY hh:mm:ss is not the one configured for Trac (ISO8601) but I tested I can use both. Also I found that our DB is not at the same time zone as Trac but if it was an issue we would have been in trouble for a long time.

[Jun Omae]

It must not import Locale symbol from any module under trac.*.

[Jun Omae]

It would be simple to use req.locale rather than Locale.negotiate (untested).

However, it should not store to _locale_string property of Component instance. Only single instance of Component is created for all threads.

mailplugin/trunk/xmail/XMailEMailModule.py

@@ -17 +17 @@
 from trac.config import IntOption
 from trac.loader import get_plugin_info
 from trac.notification import NotifyEmail
-from trac.util import translation
 from trac.util.datefmt import format_datetime
-from trac.util.translation import Locale, activate, domain_functions
+from trac.util.translation import activate, domain_functions
 from trac.web.api import ITemplateStreamFilter
 from xmail.XMailFilterObject import FilterObject
 from trac.core import Component, implements
@@ -49 +48 @@
         add_domain(self.env.path, locale_dir)
 
     def filter_stream(self, req, method, filename, stream, data):
-        if Locale and not self._TimerIsStillAlive():
-            # copied from main.py:310ff
-            available = [locale_id.replace('_', '-') for locale_id in
-                         translation.get_available_locales()]
-
-            preferred = req.session.get('language', req.languages)
-            if not isinstance(preferred, list):
-                preferred = [preferred]
-            self._locale_string = Locale.negotiate(
-                preferred, available, sep='-')
-            self.log.debug("Negotiated locale: %s -> %s",
-                           preferred, self._locale_string)
-
+        if not self._TimerIsStillAlive():
+            self._locale_string = str(req.locale) if req.locale else 'en_US'
         return stream
 
     #=========================================================================

[Jun Omae]

Other issue, db api should be used for username in the following:

xmail/XMailEMailModule.py:

242     def _get_user_data(self, username):
243         sql = ("select name, value from session_attribute where name in ('language', 'email')"
244                " and sid='%s'" % username)

xmail/XMailMainView.py:

215         sql = "select " + \
216             get_col_list(['username', 'selectfields', 'whereclause'])
217         sql += " from " + XMAIL_TABLE.name + " where username='" + \
218             req.authname + "' order by filtername"

[ntmlod]

Replying to Jun Omae:

It would be simple to use req.locale rather than Locale.negotiate (untested).

However, it should not store to _locale_string property of Component instance. Only single instance of Component is created for all threads.

mailplugin/trunk/xmail/XMailEMailModule.py

@@ -17 +17 @@
 from trac.config import IntOption
 from trac.loader import get_plugin_info
 from trac.notification import NotifyEmail
-from trac.util import translation
 from trac.util.datefmt import format_datetime
-from trac.util.translation import Locale, activate, domain_functions
+from trac.util.translation import activate, domain_functions
 from trac.web.api import ITemplateStreamFilter
 from xmail.XMailFilterObject import FilterObject
 from trac.core import Component, implements
@@ -49 +48 @@
         add_domain(self.env.path, locale_dir)
 
     def filter_stream(self, req, method, filename, stream, data):
-        if Locale and not self._TimerIsStillAlive():
-            # copied from main.py:310ff
-            available = [locale_id.replace('_', '-') for locale_id in
-                         translation.get_available_locales()]
-
-            preferred = req.session.get('language', req.languages)
-            if not isinstance(preferred, list):
-                preferred = [preferred]
-            self._locale_string = Locale.negotiate(
-                preferred, available, sep='-')
-            self.log.debug("Negotiated locale: %s -> %s",
-                           preferred, self._locale_string)
-
+        if not self._TimerIsStillAlive():
+            self._locale_string = str(req.locale) if req.locale else 'en_US'
         return stream
 
     #=========================================================================

I applied your patch but now the Xmail page loads indefinitely... Nothing in the log