Modify

Opened 7 months ago

Last modified 7 months ago

#14007 assigned enhancement

Allow code reviews on changeset page

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

It's already possible to perform code reviews on changesets. The user creates a review on the changeset page and all the files are attached to a new review. The review is then done using the review pages provided by the plugin.

Changes

It would be nice if reviews could be performed directly on the changeset page.

Things to consider:

  • Reuse the current features. Don't create a second detached review mechanism
  • Added files are only shown as links on the changeset page, no diff view at all.
  • Allow several reviews?
  • Allow commenting on source browser pages?
    • If so, how to deal with "normal" reviews created by the user using the Create Review pages?

Implementation

  • Let the user create a review on the changeset page (already implemented)
  • If there is an associated review for a changeset provide addComment() links for each line in the source browser.
  • Automatically load any available comments on page load

Attachments (0)

Change History (10)

comment:1 Changed 7 months ago by Cinc-th

In 18263:

PeerReviewPlugin: you may perform a review on the changeset page now. Administration of reviews (workflows) is still done on the review page. Some refactoring and improvements to review handling on changeset pages.

Refs #14007

comment:2 Changed 7 months ago by Cinc-th

With [18263] there is a first implementation for code reviews on changeset pages.

There're still some rough edges.

  • The user has to reload the page after creating the review to start commenting
  • Probably some new, shiny bugs

comment:3 Changed 7 months ago by Cinc-th

In 18264:

PeerReviewPlugin: don't provide addComment() links when permission is missing. Fix javascript error when some internal var is undefined. Some clean up wrt permission handling. Removed permission bug introduced while testing.

Refs #14007

comment:4 Changed 7 months ago by Cinc-th

In 18265:

PeerReviewPlugin: fixes for permission handling on changeset, view and perform pages. Permission CODE_REVIEW_VIEW was ignored and no code review data shown.

Refs #14007

comment:5 Changed 7 months ago by Cinc-th

BTW with [18264] a change was introduced which added comment links to source lines during creation of a review.

A page reload isn't necessary anymore to start commenting.

comment:6 Changed 7 months ago by Cinc-th

In 18271:

PeerReviewPlugin: minor refactoring and improvements. Files which were copied are now shown with a message in the diff view section.

Refs #14007

comment:7 Changed 7 months ago by Cinc-th

In 18284:

PeerReviewPlugin: allow to review added, copied and moved files in changesets. Up to now you had to visit the review pages for such files, see also [18271] which introduced an explanatory message for those files.

Refs #14007

comment:8 Changed 7 months ago by Cinc-th

In 18285:

PeerReviewPlugin: show spinner while creating a changeset review. Show an error box when codereview couldn'T be created.

Refs #14007

comment:9 Changed 7 months ago by Cinc-th

In 18286:

PeerReviewPlugin: review creation for a changeset failed if the changeset contained any deleted files.

Refs #14007

comment:10 Changed 7 months ago by Cinc-th

In 18287:

PeerReviewPlugin: improvements to changeset reviews:

  • Allow to create another changeset review when old review was closed.
  • Show pin icon in lines with comments
  • Hide/show comments

Some minor improvements to presentation like titles for revision links.

Refs #14007

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain Cinc-th.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.