Modify

Opened 10 years ago

Closed 10 years ago

#1893 closed defect (fixed)

Starting work does not get logged

Reported by: aig Owned by: Colin Guthrie
Priority: normal Component: WorkLogPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.10

Description

I installed the plugin on trac 0.10.4 and I can see the Work Log box on top of each ticket. When I click the Start Work button, I am taken to the worklog page and it says "You are now working on ticket #1" (for example). Below that it does not list that I'm working on the ticket. Going back to the ticket page then says "Nobody is working on this ticket."

Clicking the button yields the following requests:
"POST /proj/worklog HTTP/1.1" 200 -
"GET /proj/chrome/site/banner.JPG HTTP/1.1" 304 -

Attachments (1)

manager.py.diff (440 bytes) - added by anonymous 10 years ago.
transaction commit in manager.py

Download all attachments as: .zip

Change History (6)

comment:1 in reply to:  description Changed 10 years ago by aig

No records are recorded into the work_log table either.

comment:2 Changed 10 years ago by Colin Guthrie

I suspect I'm not committing a transaction somewhere.... I'll try and take a look but it works for me right now! You can perhaps see if there should be a db.commit() some where.... it'll probably be in the manager class

comment:3 in reply to:  2 Changed 10 years ago by aig

Replying to coling:

Thanks for the fast response, I'll give it a shot when I get some free time to play around at work ;)

Changed 10 years ago by anonymous

Attachment: manager.py.diff added

transaction commit in manager.py

comment:4 in reply to:  2 Changed 10 years ago by anonymous

Replying to coling:

I suspect I'm not committing a transaction somewhere.... I'll try and take a look but it works for me right now! You can perhaps see if there should be a db.commit() some where.... it'll probably be in the manager class

Hi coling:

I've found the place where the transaction was missing. I've attached a file with the patch that is working for me (attachment:ticket:1893:manager.py.diff)

Regards,

Alfonso.

comment:5 Changed 10 years ago by Colin Guthrie

Resolution: fixed
Status: newclosed

(In [2571]) Fixes #1893 by applying a modified patch. Found another place missing a commit, but it may have been mitigated under certain circumstances. Thanks to Alfonso for spotting it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Colin Guthrie.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.