Modify

Opened 9 years ago

Closed 9 years ago

#3188 closed defect (invalid)

Add user combobox is empty, can't create a code review

Reported by: anonymous Owned by: Sebastian Marek
Priority: high Component: PeerReviewPlugin
Severity: major Keywords: bug
Cc: Trac Release: 0.11

Description

I'm using Trac 0.11rc2 and PeerReview? 2.2-dev branch.

When I try to create a new code review I'm unable to add any users because the combobox is empty (although I do have several users in that trac environment).

I see the following in my Apache error log:

File does not exist: /path/to/apache/doc/root/trac-mysql, referer: http://myserver.com/trac/SomeProject/peerReviewMain

This trac environment is using sqlite, so I don't get this thing with mysql.

Attachments (0)

Change History (3)

comment:1 Changed 9 years ago by Sebastian Marek

Yes, I've spotted that too. Thanks for raising a ticket for that. But it's not responsible for empty users lists - make sure that users you want to see in that list have CODE_REVIEW_DEV permission assigned.

comment:2 in reply to:  1 Changed 9 years ago by anonymous

Replying to proofek:

Yes, I've spotted that too. Thanks for raising a ticket for that. But it's not responsible for empty users lists - make sure that users you want to see in that list have CODE_REVIEW_DEV permission assigned.

Thanks! CODE_REVIEW_DEV seems to fix the problem. But I would suggest that users with TRAC_ADMIN have this permissions anyway as we need some kind of evyrything-is-allowed permission and now it's TRAC_ADMIN. The point is that our scripts create new trac environments and set TRAC_ADMIN to everyone who has access to it. Sure we can modify those scripts, but it seems like it would be better if TRAC_ADMIN contained CODE_REVIEW_* in itself.

comment:3 Changed 9 years ago by anonymous

Resolution: invalid
Status: newclosed

maybe you could print out a hint?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Sebastian Marek.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.