Modify

Opened 9 years ago

Closed 3 years ago

Last modified 3 years ago

#3222 closed defect (fixed)

[Patch] Allow group names to have *some* upper-case letters

Reported by: dean.harding@… Owned by: Ryan J Ollos
Priority: normal Component: PrivateTicketsPlugin
Severity: minor Keywords: groups
Cc: Trac Release: 0.10

Description

Line 125 of policy.py has the following code:

    if subject in groups and action.islower() and action not in groups

This assumes that group names are all lower-case, but that's not necessarily true -- the help text on the "permissions" page in Admin says (emphasis added):

"Note that Subject or Group names can't be all upper cased, as this is reserved for permission names."

Some of our group names have upper case characters in them, and so I had to change line 125 to read:

    if subject in groups and not action.isupper() and action not in groups

That change made it work nicely with our setup. Great plugin, by the way -- extremely useful :-)

Attachments (0)

Change History (9)

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: Group names can have upper-case lettersAllow group names to have *some* upper-case letters

#5165 closed as a duplicate.

comment:2 Changed 7 years ago by Ryan J Ollos

#6278 closed as a duplicate.

comment:3 Changed 6 years ago by Ryan J Ollos

Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newassigned
Summary: Allow group names to have *some* upper-case letters[Patch] Allow group names to have *some* upper-case letters

comment:4 Changed 6 years ago by Ryan J Ollos

(In [9814]) Allow group names to have *some* upper case characters. Thanks to Dean Harding for the patch. Fixes #3222.

comment:5 Changed 5 years ago by Ryan J Ollos

The fix in [9814] is consistent with similar code in the Trac source for DefaultPermissionStore.get_user_permissions:

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 5 years ago by Ryan J Ollos

This ticket will be left open for feedback and resolved with milestone 2.1 (#9964)

comment:7 Changed 4 years ago by Ryan J Ollos

Status: assignednew

comment:8 Changed 3 years ago by Ryan J Ollos

Status: newassigned

comment:9 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.