[Patch] Allow group names to have *some* upper-case letters

[dean.harding@…]

Line 125 of policy.py has the following code:

    if subject in groups and action.islower() and action not in groups

This assumes that group names are all lower-case, but that's not necessarily true -- the help text on the "permissions" page in Admin says (emphasis added):

"Note that Subject or Group names can't be all upper cased, as this is reserved for permission names."

Some of our group names have upper case characters in them, and so I had to change line 125 to read:

    if subject in groups and not action.isupper() and action not in groups

That change made it work nicely with our setup. Great plugin, by the way -- extremely useful :-)

[Ryan J Ollos]

#5165 closed as a duplicate.

[Ryan J Ollos]

#6278 closed as a duplicate.

[Ryan J Ollos]

(In [9814]) Allow group names to have *some* upper case characters. Thanks to Dean Harding for the patch. Fixes #3222.

[Ryan J Ollos]

The fix in [9814] is consistent with similar code in the Trac source for DefaultPermissionStore.get_user_permissions:

• ​Trac 0.11
• ​Trac Trunk (0.13dev)

[Ryan J Ollos]

This ticket will be left open for feedback and resolved with milestone 2.1 (#9964)