Modify

Opened 9 years ago

Last modified 11 days ago

#3836 new enhancement

[PATCH] Disable gridmodify until explicitly enabled

Reported by: shez@… Owned by:
Priority: normal Component: GridModifyPlugin
Severity: normal Keywords:
Cc: jonathan.trackhacks@…, falkb Trac Release: 0.11

Description (last modified by Ryan J Ollos)

Hi,

GridModifyPlugin is almost very useful to us, unfortunately certain reports we use (for example those from the TimingAndEstimationPlugin) look pretty nasty when it is enabled.

This would be a non problem if reports and queries had an extra option/link/button you could select to turn on the GridModifyBehaviour - because you sometimes just want to look, not edit :)

Cheers Shez

Attachments (2)

web_ui.py (13.5 KB) - added by Jonathan Hofman 6 years ago.
Added an checkbox to disable/enable the grid modify in the report overview
11274.patch (16.1 KB) - added by Jonathan Hofman 6 years ago.
patch on gridmodify/trunk (rev11274)

Download all attachments as: .zip

Change History (23)

comment:1 Changed 9 years ago by sincoder

Priority: normalhighest
Trac Release: 0.100.11

I second this

comment:2 Changed 8 years ago by pr@…

Hello,

Moreover, it could be great to choose fields we want editable in the grid for each report. Very nice plugin!

Cheers,

Pierre

comment:3 Changed 7 years ago by maburns@…

bump. I'd love to have a single report that was grid-editable, but leave others normal.

comment:4 Changed 7 years ago by anonymous

Owner: changed from Abbywinters.com WebDev to anonymous
Priority: highestnormal
Status: newassigned

comment:5 Changed 7 years ago by Björn Harrtell

Owner: changed from anonymous to Björn Harrtell
Status: assignednew

comment:6 Changed 7 years ago by Björn Harrtell

Status: newassigned

comment:7 Changed 7 years ago by Björn Harrtell

Status: assignednew

comment:8 Changed 7 years ago by anonymous

Priority: normalhigh

comment:9 Changed 6 years ago by david.killick@…

I was about to raise an almost identical feature request - to have a mechanism to turn the grid modify on and off - as its a very useful plugin, but less so if its 'always on'.

comment:10 Changed 6 years ago by Jonathan Hofman

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Changed 6 years ago by Jonathan Hofman

Attachment: web_ui.py added

Added an checkbox to disable/enable the grid modify in the report overview

comment:11 Changed 6 years ago by Jonathan Hofman

Cc: jonathan.trackhacks@… added; anonymous removed

comment:12 in reply to:  10 ; Changed 6 years ago by Ryan J Ollos

Replying to jonathanhofman:

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Could you please attach that as a patch, or at least report the revision that it was developed against?

Changed 6 years ago by Jonathan Hofman

Attachment: 11274.patch added

patch on gridmodify/trunk (rev11274)

comment:13 in reply to:  12 Changed 6 years ago by Jonathan Hofman

Summary: It would be nice to be able to have gridmodify off until a link or checkbox is selected[PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected

Replying to rjollos:

Replying to jonathanhofman: Could you please attach that as a patch, or at least report the revision that it was developed against?

I've appended the patch. It was made agains the the lates revision 11274 on the trunk. It adds a checkbox. If you like it, would you add it to the code so it is included in future versions. As I said before, I'm fairly new to trac, so I don't know if this is the best way to do it. Comments are welcome.

comment:14 Changed 6 years ago by Ryan J Ollos

Description: modified (diff)

comment:15 Changed 5 years ago by Ryan J Ollos

Further we might want to store the value in the session data.

comment:16 in reply to:  15 Changed 5 years ago by Jonathan Hofman

Replying to rjollos:

Further we might want to store the value in the session data.

Unfortunately there is a bug or a change in the current trac code causing the checkbox not to work anymore, because indeed the value is not saved. I have to look in to that, because it is a pretty nice feature when it is working.

When I have fixed it, I will post the new patch.

comment:17 Changed 5 years ago by Ryan J Ollos

While working on #10519, it occurred to me that it would be nice to also be able to toggle notifications off with a checkbox, as the BatchModifyPlugin allows.

comment:18 Changed 5 years ago by Ryan J Ollos

Owner: changed from Björn Harrtell to Ryan J Ollos
Priority: highnormal

comment:19 Changed 5 years ago by falkb

Cc: falkb added

I second this ticket a lot

comment:20 Changed 5 years ago by Ryan J Ollos

Summary: [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected[PATCH] Disable gridmodify until explicitly enabled

comment:21 Changed 11 days ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.