[PATCH] Disable gridmodify until explicitly enabled

[shez@…]

Hi,

GridModifyPlugin is almost very useful to us, unfortunately certain reports we use (for example those from the TimingAndEstimationPlugin) look pretty nasty when it is enabled.

This would be a non problem if reports and queries had an extra option/link/button you could select to turn on the GridModifyBehaviour - because you sometimes just want to look, not edit :)

Cheers Shez

[sincoder]

I second this

[pr@…]

Hello,

Moreover, it could be great to choose fields we want editable in the grid for each report. Very nice plugin!

Cheers,

Pierre

[maburns@…]

bump. I'd love to have a single report that was grid-editable, but leave others normal.

[david.killick@…]

I was about to raise an almost identical feature request - to have a mechanism to turn the grid modify on and off - as its a very useful plugin, but less so if its 'always on'.

[Jonathan Hofman]

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

[Jonathan Hofman]

Added an checkbox to disable/enable the grid modify in the report overview

[Ryan J Ollos]

Replying to jonathanhofman:

I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.

Could you please attach that as a patch, or at least report the revision that it was developed against?

[Jonathan Hofman]

patch on gridmodify/trunk (rev11274)

[Jonathan Hofman]

Replying to rjollos:

Replying to jonathanhofman: Could you please attach that as a patch, or at least report the revision that it was developed against?

I've appended the patch. It was made agains the the lates revision 11274 on the trunk. It adds a checkbox. If you like it, would you add it to the code so it is included in future versions. As I said before, I'm fairly new to trac, so I don't know if this is the best way to do it. Comments are welcome.

[Ryan J Ollos]

Further we might want to store the value in the session data.

[Jonathan Hofman]

Replying to rjollos:

Further we might want to store the value in the session data.

Unfortunately there is a bug or a change in the current trac code causing the checkbox not to work anymore, because indeed the value is not saved. I have to look in to that, because it is a pretty nice feature when it is working.

When I have fixed it, I will post the new patch.

[Ryan J Ollos]

While working on #10519, it occurred to me that it would be nice to also be able to toggle notifications off with a checkbox, as the BatchModifyPlugin allows.

[falkb]

I second this ticket a lot