Opened 16 years ago
Last modified 7 years ago
#3836 new enhancement
[PATCH] Disable gridmodify until explicitly enabled
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Component: | GridModifyPlugin |
Severity: | normal | Keywords: | |
Cc: | jonathan.trackhacks@…, falkb | Trac Release: | 0.11 |
Description (last modified by )
Hi,
GridModifyPlugin is almost very useful to us, unfortunately certain reports we use (for example those from the TimingAndEstimationPlugin) look pretty nasty when it is enabled.
This would be a non problem if reports and queries had an extra option/link/button you could select to turn on the GridModifyBehaviour - because you sometimes just want to look, not edit :)
Cheers Shez
Attachments (2)
Change History (23)
comment:1 Changed 16 years ago by
Priority: | normal → highest |
---|---|
Trac Release: | 0.10 → 0.11 |
comment:2 Changed 15 years ago by
Hello,
Moreover, it could be great to choose fields we want editable in the grid for each report. Very nice plugin!
Cheers,
Pierre
comment:3 Changed 14 years ago by
bump. I'd love to have a single report that was grid-editable, but leave others normal.
comment:4 Changed 14 years ago by
Owner: | changed from Abbywinters.com WebDev to anonymous |
---|---|
Priority: | highest → normal |
Status: | new → assigned |
comment:5 Changed 14 years ago by
Owner: | changed from anonymous to Björn Harrtell |
---|---|
Status: | assigned → new |
comment:6 Changed 14 years ago by
Status: | new → assigned |
---|
comment:7 Changed 14 years ago by
Status: | assigned → new |
---|
comment:8 Changed 14 years ago by
Priority: | normal → high |
---|
comment:9 Changed 13 years ago by
I was about to raise an almost identical feature request - to have a mechanism to turn the grid modify on and off - as its a very useful plugin, but less so if its 'always on'.
comment:10 follow-up: 12 Changed 13 years ago by
I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.
Changed 13 years ago by
Added an checkbox to disable/enable the grid modify in the report overview
comment:11 Changed 13 years ago by
Cc: | jonathan.trackhacks@… added; anonymous removed |
---|
comment:12 follow-up: 13 Changed 13 years ago by
Replying to jonathanhofman:
I've modified the plugin to show an checkbox to enable/disable gridmodify. I don't know this is the way to implement it, but it works.
Could you please attach that as a patch, or at least report the revision that it was developed against?
comment:13 Changed 13 years ago by
Summary: | It would be nice to be able to have gridmodify off until a link or checkbox is selected → [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected |
---|
Replying to rjollos:
Replying to jonathanhofman: Could you please attach that as a patch, or at least report the revision that it was developed against?
I've appended the patch. It was made agains the the lates revision 11274 on the trunk. It adds a checkbox. If you like it, would you add it to the code so it is included in future versions. As I said before, I'm fairly new to trac, so I don't know if this is the best way to do it. Comments are welcome.
comment:14 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:15 follow-up: 16 Changed 12 years ago by
Further we might want to store the value in the session data.
comment:16 Changed 12 years ago by
Replying to rjollos:
Further we might want to store the value in the session data.
Unfortunately there is a bug or a change in the current trac code causing the checkbox not to work anymore, because indeed the value is not saved. I have to look in to that, because it is a pretty nice feature when it is working.
When I have fixed it, I will post the new patch.
comment:17 Changed 12 years ago by
While working on #10519, it occurred to me that it would be nice to also be able to toggle notifications off with a checkbox, as the BatchModifyPlugin allows.
comment:18 Changed 12 years ago by
Owner: | changed from Björn Harrtell to Ryan J Ollos |
---|---|
Priority: | high → normal |
comment:20 Changed 12 years ago by
Summary: | [PATCH] It would be nice to be able to have gridmodify off until a link or checkbox is selected → [PATCH] Disable gridmodify until explicitly enabled |
---|
comment:21 Changed 7 years ago by
Owner: | Ryan J Ollos deleted |
---|
I second this