SvnAuthzAdmin path calculations incorrect on Windows

[Chris Heller]

SvnAuthzAdminPlugin uses Python's url2pathname() function to go from the current URL to the relative path in the svn authz file format.

The svn authz format is always with URL or Unix style paths ('/' instead of '\'), so when using this plugin on Windows, the path calculations are incorrect.

[Chris Heller]

What I did to get around this issue is to add the following at the top of the admin_ui.py file.

import sys
is_windows = sys.platform.startswith('win')
del sys

def url2localpathname(url):
    """ 
    Fix up paths returned by url2pathname so that authz format is correct 
    on Windows as well as *nix flavors
    """
    localpath = url2pathname(url)
    if is_windows:
        localpath = localpath.replace('\\', '/')
    return localpath    

and then change all other references to url2pathname to use the newly defined url2localpathname

[rupert thurner]

would you mind creating a patch please?

[Sergio Talens-Oliag]

Patch to replace url2pathname and pathname2url by quote and unquote

[Sergio Talens-Oliag]

Replying to ThurnerRupert:

would you mind creating a patch please?

I've created a different patch​ replacing the use of url2pathname and pathname2url by quote and unquote, as that is what is needed to process the svnauth paths (in UNIX systems the functions url2pathname and pathname2url are equivalent to quote and unquote and the svnauth file uses UNIX like paths, so we don't need to use the system dependent functions).

[Jun Omae]

In 18641:

SvnAuthzAdminPlugin 1.0.1dev: fix fatal raising when non-ascii groups and paths used, and remove uses of pathname2url and url2pathname (closes #5484, #7871, #5302, #12314)