Modify

Opened 7 years ago

Last modified 6 months ago

#5395 assigned enhancement

[Patch] Add keywords to reviews

Reported by: filthycoder Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Our team needs to track reviews by Feature-IDs. To accomplish that it would be very nice to have a "Feature ID" field per review.

But I understand that other people do not need this, or name it differently. So I just want to ask for a "keywords" field where everybody can use it after its own desire.

Attachments (2)

patch_keywords_against_2.1_toddlerdev_r5257.diff.zip (5.8 KB) - added by filthycoder 7 years ago.
zipped because else it got rejected
patch_timeline_data.diff (1023 bytes) - added by filthycoder 7 years ago.
correcting keywords handling in timeline

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by filthycoder

zipped because else it got rejected

comment:1 follow-up: Changed 7 years ago by filthycoder

The patch alters the CodeReviews table with an additional column Keywords.

Also included is a script for updating an existing database to the newly defined version (2).

Hopefully all pages are correctly updated and showing the keywords column. Search is also included.

comment:2 in reply to: ↑ 1 Changed 7 years ago by filthycoder

Replying to filthycoder:

Also included is a script for updating an existing database to the newly defined version (2).

With "script" I meant using the trac-admin upgrade machanism.

comment:3 Changed 7 years ago by filthycoder

depends on r5401 for update script

comment:4 Changed 7 years ago by filthycoder

  • Owner changed from proofek to filthycoder
  • Status changed from new to assigned

Changed 7 years ago by filthycoder

correcting keywords handling in timeline

comment:5 Changed 7 years ago by rjollos

  • Summary changed from add keywords to reviews (patch included) to [Patch] Add keywords to reviews

comment:6 Changed 6 months ago by Cinc-th

In 15192:

Upgrade for database schema to version 2.

  • all table and column names are lower case now
  • table names are prepended by peer_ to prevent name clashes
  • added some columns for future features
  • uses Trac upgrade framework
  • table contents is properly migrated

Note that the upgrade is only tested with SQLite.

Refs #10812
Refs #5395
Fixes #5808
Fixes #5401



comment:7 Changed 6 months ago by Cinc-th

  • Owner changed from filthycoder to Cinc-th
  • Trac Release changed from 0.11 to 0.12

With [15192] there is now a keywords column in the database table holding reviews. No way for the user to set the value for now.

Add Comment

Modify Ticket

Action
as assigned The owner will remain Cinc-th.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.