Modify

Opened 7 years ago

Closed 6 years ago

#7232 closed defect (fixed)

Explicit separator required in date string

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: WikiCalendarMacro
Severity: normal Keywords: date/time format
Cc: Ryan J Ollos Trac Release: 0.11

Description (last modified by Ryan J Ollos)

We had to set the seperator 'sep' in wikiticketcalendar/macro.py hard coded to "/" to make it work

duedate = { 'dmy': '%(dd)s%(sep)s%(mm)s%(sep)s%(yy)s',
                                'mdy': '%(mm)s%(sep)s%(dd)s%(sep)s%(yy)s',
                                'ymd': '%(yy)s%(sep)s%(mm)s%(sep)s%(dd)s'
                    }.get(self.date_format,
                    '%(yy)s%(sep)s%(mm)s%(sep)s%(dd)s') % {
                        'dd': dayString,
                        'mm': monthString,
                        'yy': yearString,
                        'sep': "/"
                    }

Attachments (0)

Change History (6)

comment:1 Changed 7 years ago by Ryan J Ollos

Cc: Steffen Hoffmann added; anonymous removed
Summary: separator in date stringExplicit separator required in date string

This ticket was incorrectly opened against the WikiCalendarMacro.

comment:2 Changed 7 years ago by Steffen Hoffmann

Keywords: date/time format added

I'll have a look at it as soon as time permits. Thanks for taking care and contributing both, problem and a possible solution.

I'll just leave it here, as the maintainer did not feel the urge to move nor to close it right away.

If you subscribe with your email address and a short comment, I'll know, it's time to move it over to the pile of issues for WikiTicketCalendarMacro, where it belongs indeed.

comment:3 Changed 7 years ago by Ryan J Ollos

Thanks for the note hasienda. I had meant to move it over to WikiTicketCalendarMacro, but if you want to leave it here, that's fine with me. My job (startup company at which I have many roles) has not allowed me much time to focus on improving Trac lately, but I hope to have some time to contribute to WikiCalendarMacro and WikiTicketCalendarMacro within the next few months.

comment:4 Changed 7 years ago by Steffen Hoffmann

There has been done considerably efforts to improve the 'sister' plugin WikiTicketCalendarMacro.

With regards to #7564 I'd appreciate, if you could test your issue with the current version of WikiTicketCalendarMacro as well and report back here. I can't make promises, but this might be a big step towards solving this issue. Thank you for your patience and for helping us with improvements.

It might be relevant, that I've removed that dependency of (WikiTicketCalendarMacro) getting self.date_format from DateFieldPlugin's section in trac.ini, because it was both, not easy to spot and hard to fulfill without installing DateFieldPlugin itself - all in all a ugly thing.

comment:5 Changed 7 years ago by Ryan J Ollos

Description: modified (diff)
Owner: changed from Ryan J Ollos to Steffen Hoffmann

comment:6 Changed 6 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added; Steffen Hoffmann removed
Resolution: fixed
Status: newclosed

I thought I had it moved over too, anyway.

As mentioned before, the issue reported here has been resolved in changeset [8270] for WikiTicketCalendarMacro trunk branch and has been backported to the 0.11 branch (single file plugin) with [8314] released as WikiTicketCalendarMacro v0.8.5 .

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.