Opened 7 years ago

Closed 2 years ago

Last modified 2 years ago

#7511 closed enhancement (fixed)

Hack deletion

Reported by: Michael Renzmann Owned by: Ryan J Ollos
Priority: normal Component: TracHacksPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos, Michael Renzmann, Odd Simon Simonsen, Jun Omae Trac Release: 0.12


Add something that allows to delete hacks when necessary. This should reverse all changes that had been done when the hack has been registered. See also #5785.

Attachments (0)

Change History (11)

comment:1 Changed 7 years ago by Michael Renzmann

Owner: changed from Alec Thomas to Michael Renzmann

comment:2 Changed 7 years ago by Michael Renzmann

Status: newassigned

comment:3 Changed 7 years ago by Ryan J Ollos

Cc: Ryan J Ollos added; anonymous removed

comment:4 Changed 4 years ago by Steffen Hoffmann

Cc: Michael Renzmann Odd Simon Simonsen added

I'm not entirely sure, if one should be allowed to delete even its own hack.

Deleting the hack branch in the repository is likely possible for the hack author/maintainer even now. Note though, this is more like moving documents to the recycle bin than a true deletion. The reason behind is, that in general a changeset cannot be withdrawn from a repository as well, at least not without altering history. While this leads to seemingly religious discussions, I feel, that it is common sense to not do that at least for public repositories.

Deleting wiki pages is reserved to admin for good reasons. I'd strongly suggest to not go for a more liberal approach, because it works without problems AFAICS.

To summarize, there are strong arguments against making hack deletion as easy as deleting user accounts. I suggest to leave it to the admin group. Thoughts?

comment:5 in reply to:  4 Changed 4 years ago by Ryan J Ollos

Replying to hasienda:

I suggest to leave it to the admin group. Thoughts?

Yes, I think it is best to leave it to the admin group. When I read this a while back, I assumed that is what otaku42 had in mind when creating this ticket.

For admins, it would provide a convenient way to clean up after spam hack creations. I've only seen a few of those so far, but I can see an advantage to making it a one-step process: remove the wiki page, component, tickets for component and repository with one command.

comment:6 Changed 4 years ago by Ryan J Ollos

Cc: Jun Omae added

The manual steps to remove a hack are:

  • Delete the Component.
  • Close tickets associated with the Component.
  • Remove entries from the svn authz file.
  • Delete the wiki page.
  • Delete the directory from the repository.

It should be fairly straightforward to execute those operations from a Delete Hack button on an admin page.

comment:7 Changed 2 years ago by Ryan J Ollos

Owner: changed from Michael Renzmann to Ryan J Ollos

comment:8 Changed 2 years ago by Ryan J Ollos

Status: assignednew

comment:9 Changed 2 years ago by Ryan J Ollos

In 14957:

3.0.0dev: Delete hack assets when Component deleted.

When a component is deleted from the Component Admin page (/admin/ticket/components), the following are deleted:

  • Wiki page.
  • Entry in SVN authz file.
  • Repository path.

Refs #7511.

comment:10 Changed 2 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

Note that I didn't address the issue of deleting tickets associated with a hack. If the tickets are spam they should be deleted as part of the normal spam removal process. If the tickets are not spam, such as the case of removing an obsolete plugin, then I think it's better to just close all the tickets.

comment:11 Changed 2 years ago by Ryan J Ollos

In 14970:

3.0.0dev: Default to binary on system path.

This revises changeset [14957].

Refs #7511.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.