#7511 closed enhancement (fixed)
Hack deletion
| Reported by: | Michael Renzmann | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Component: | TracHacksPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Ryan J Ollos, Michael Renzmann, osimons, Jun Omae | Trac Release: | 0.12 |
Description
Add something that allows to delete hacks when necessary. This should reverse all changes that had been done when the hack has been registered. See also #5785.
Attachments (0)
Change History (12)
comment:1 Changed 14 years ago by
| Owner: | changed from Alec Thomas to Michael Renzmann |
|---|
comment:2 Changed 14 years ago by
| Status: | new → assigned |
|---|
comment:3 Changed 14 years ago by
| Cc: | Ryan J Ollos added; anonymous removed |
|---|
comment:4 follow-up: 5 Changed 11 years ago by
| Cc: | Michael Renzmann osimons added |
|---|
comment:5 Changed 11 years ago by
Replying to hasienda:
I suggest to leave it to the admin group. Thoughts?
Yes, I think it is best to leave it to the admin group. When I read this a while back, I assumed that is what otaku42 had in mind when creating this ticket.
For admins, it would provide a convenient way to clean up after spam hack creations. I've only seen a few of those so far, but I can see an advantage to making it a one-step process: remove the wiki page, component, tickets for component and repository with one command.
comment:6 Changed 11 years ago by
| Cc: | Jun Omae added |
|---|
The manual steps to remove a hack are:
- Delete the Component.
- Close tickets associated with the Component.
- Remove entries from the svn authz file.
- Delete the wiki page.
- Delete the directory from the repository.
It should be fairly straightforward to execute those operations from a Delete Hack button on an admin page.
comment:7 Changed 9 years ago by
| Owner: | changed from Michael Renzmann to Ryan J Ollos |
|---|
comment:8 Changed 9 years ago by
| Status: | assigned → new |
|---|
comment:10 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note that I didn't address the issue of deleting tickets associated with a hack. If the tickets are spam they should be deleted as part of the normal spam removal process. If the tickets are not spam, such as the case of removing an obsolete plugin, then I think it's better to just close all the tickets.
I'm not entirely sure, if one should be allowed to delete even its own hack.
Deleting the hack branch in the repository is likely possible for the hack author/maintainer even now. Note though, this is more like moving documents to the recycle bin than a true deletion. The reason behind is, that in general a changeset cannot be withdrawn from a repository as well, at least not without altering history. While this leads to seemingly religious discussions, I feel, that it is common sense to not do that at least for public repositories.
Deleting wiki pages is reserved to admin for good reasons. I'd strongly suggest to not go for a more liberal approach, because it works without problems AFAICS.
To summarize, there are strong arguments against making hack deletion as easy as deleting user accounts. I suggest to leave it to the admin group. Thoughts?