Opened 7 years ago

Closed 6 years ago

Never Notify Updater (merge feature from trunk to 0.11dev branch)

Reported by: Owned by: josh@… Steffen Hoffmann normal AnnouncerPlugin normal nevernotify Steffen Hoffmann 0.11

Description

Would it be possible to integrate the functionality of the NeverNotifyUpdaterPlugin into this one? (That is, have an option which I can check if I never want to be notified of my own updates).

comment:1 Changed 7 years ago by Ryan J Ollos

Please take a look at #7424. I believe the functionality you are requesting already exists, but if not, we'll need more specific information.

comment:2 follow-up:  12 Changed 7 years ago by anonymous

It's entirely possible that this functionality has been integrated into a newer version - I'm deploying this in a production environment, so I pulled from 0.11 folder, as opposed to 0.11dev or trunk.

I had issues with trying to get the trunk version to run on our setup - do you know if this functionality is present in the 0.11dev branch?

comment:3 Changed 7 years ago by Ryan J Ollos

I'm almost certain the functionality is present in the 0.11 directory, since I was running that version until 2 weeks back. Its definitely present in 0.11dev.

comment:4 Changed 7 years ago by josh@…

I can't find any reference to it in the checkout of 0.11dev that I just did. Are you sure?

comment:5 Changed 7 years ago by Ryan J Ollos

It should be on the Announcer panel of the Preferences page (in the meta navigation).

comment:6 Changed 7 years ago by josh@…

I know it /should/ be there. What I'm saying is, there's not a single reference to the string 'Never notify me of my own changes to tickets' anywhere in the code. In fact, the word 'never' only appears twice in the entire 0.11dev folder - both those times are in comments in api.py. As far as I can tell, this option has only been introduced in the trunk folder.

comment:7 Changed 7 years ago by Ryan J Ollos

I guess I must be running a patched version of 0.11 then. I need to track down the ticket where this was discussed. Is it safe to assume that unchecking Notify me when I update a ticket. doesn't give the desired behavior?

comment:8 Changed 7 years ago by Ryan J Ollos

You might take a look at #4002.

comment:9 Changed 7 years ago by Ryan J Ollos

Cc: Steffen Hoffmann added; anonymous removed

This is coming back to me now ... I'm pretty sure I'm running the 0.11 branch with the patch from #4002. Since this has come up now twice, maybe we should look into merging #4002 into 0.11dev.

comment:10 Changed 7 years ago by josh@…

Heh, no, unfortunately unticking that box does not produce the desired effect. It seems that if any of the other options returns true, you still get an email.

I'll take a look at that ticket when I have a chance. If it does work, then merging it into 0.11dev (or backporting that particular change from the trunk) would be nice for those of us who can't migrate to 0.12 yet.

comment:11 Changed 7 years ago by Ryan J Ollos

Summary: Never Notify Updater → Never Notify Updater (merge feature from trunk to 0.11dev branch)

comment:12 in reply to:  2 ; follow-up:  13 Changed 7 years ago by Steffen Hoffmann

Keywords: nevernotify added changed from Robert Corsaro to Steffen Hoffmann new → assigned

I had issues with trying to get the trunk version to run on our setup - do you know if this functionality is present in the 0.11dev branch?

Sure, if you try to run trunk on 0.11.x it wouldn't even package for you, since the new i18n stuff does rely on a recent version of Babel and new code from Trac, that is only available in late 0.12dev and the current stable release 0.12 itself.

Actually I'm thinking how to reorganize with 0.12 out now. The crypto functionality from trunk may be interesting for 0.11 as well, and it could be back-ported easily AFAICS. I've already prepared some revisions for AnnouncerPlugin, so may have time to do some work this coming weekend. If so, I'll certainly take care of this issue as well. Hope that'll help.

comment:13 in reply to:  12 ; follow-up:  14 Changed 7 years ago by Ryan J Ollos

Actually I'm thinking how to reorganize with 0.12 out now.

I think you had mentioned in another ticket, merging 0.11dev in 0.11 - I definitely think that is a good idea. After that, perhaps move 0.11 to branches/0.11. That structure would probably make sense to far more people than the current structure.

comment:14 in reply to:  13 Changed 7 years ago by Steffen Hoffmann

Actually I'm thinking how to reorganize with 0.12 out now.

I think you had mentioned in another ticket, merging 0.11dev in 0.11 - I definitely think that is a good idea. After that, perhaps move 0.11 to branches/0.11. That structure would probably make sense to far more people than the current structure.

Thanks for encouraging me to do so. Did with WikiTicketCalendarMacro before, but was unsure, if this would be generally acceptable, since it's definitely against the de-facto standard of having Trac release branches at the repo root of each plugin directory.

BTW, the 0.11dev -> 0.11 merge has already been committed with r8410. As always comments are appreciated.

comment:15 Changed 7 years ago by Steffen Hoffmann

Now I've taken a look a the implementation in trunk. I'll need to put related things from various changesets together. As soon as I've done this, it will need some testing for sure.

comment:16 Changed 6 years ago by Robert Corsaro

I'll dive deeper into this when I get a chance, but somewhere along the line I had to completely restructure the subscription algorithm to accommodate filtering. I'm not sure if that feature is, or should be, back ported to 0.11. I think a better strategy is to figure out why there are incompatibilities between trunk and 0.11 trac and fix them, rather then back port features.

comment:17 Changed 6 years ago by Robert Corsaro

Resolution: → wontfix assigned → closed

As I thought, the ability to remove subscriptions after collecting them is not in the old branches. You'll have to upgrade to get this feature.

Modify Ticket

Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.