[Patch] bookmark.url not being expanded correctly on sub sites

[branson]

• I have a site at /trac/atol
• have the most recent bookmarks plugin
• we are seeing this:

    <ul class="bookmarks">
        <li class="report">
            <a href="/report/8">{8}</a>
                Active Tickets, Mine first (<a href="/trac/atol/bookmark/delete_in_page/report/8">delete</a>)
        </li>
    </ul>

for code that looks like this in the list.html template:

 <ul class="bookmarks">
      <py:for each="bookmark in bookmarks">
        <li class="${bookmark.realm}">
            <a href="${bookmark.url}">${bookmark.linkname}</a>
                ${bookmark.name} (<a href="${bookmark.delete}">delete</a>)
        </li>
      </py:for>
    </ul>

appears that the bookmark.url is not being expanded correctly.

[Ryan J Ollos]

#9788, which I opened, is a duplicate.

[Jun Omae]

(In [11271]) Fixed generating wrong bookmark urls if base-path isn't /.

Initial patch by sandinak. Closes #8628.

[Ryan J Ollos]

Hi jun66j5,

Did you test that patch on bookmarks with hrefs that contain query strings? I did some testing on hrefs that contain query strings in the course of my work on #7399, and then again while starting to work on #9788, and found that using req.href(url) doesn't work for query strings (more details in #9788). I was thinking that req.base_path + url might work better here. I implemented a similar solution for the MenusPlugin in [11166]. I was thinking that a cleaner implementation there might be req.base_path + url.lstrip('/'), but I haven't tried that out yet.

[Jun Omae]

Oh..., you're right. I try now and it doesn't work on url with query string.

[Ryan J Ollos]

I've seen a similar issue with at least 3 other Trac plugins, so I'll be interested to see what solution you implement since I think you know the Trac API much better than I do. It would be really nice if req.href(..) could just handle query arguments and fragments though.

[Ryan J Ollos]

Also, I can't say for certain, but think that #8353 was probably resolved by this patch as well. At least, I think I may have experienced that issue yesterday when working in a dev instance of Trac, and prior to this patch.

[Jun Omae]

(In [11272]) Follow-up to [11271], fixed generating wrong link when a page with query string is bookmarked.

Closes #8628.