Modify ↓
Opened 13 years ago
Closed 13 years ago
#9788 closed defect (duplicate)
base_path is not prefixed to links on the /bookmark page
Reported by: | Ryan J Ollos | Owned by: | yosiyuki |
---|---|---|---|
Priority: | normal | Component: | BookmarkPlugin |
Severity: | normal | Keywords: | |
Cc: | Jun Omae | Trac Release: | 0.12 |
Description
If you have a base_path
, e.g. your URLs are localhost/project/ticket
rather than localhost/ticket
. the base_path
is not properly prefixed to links on the bookmark
page.
To reproduce:
- Add a bookmark (
timeline
in this example) - Navigate to the bookmark page. Click on the resource link (
timeline
in this example`)
Environment not found will be displayed.
The function __format_name
prepares the request data, so I've made the fix in that function in the simplest possible way:
-
0.12/tracbookmark/__init__.py
### Eclipse Workspace Patch 1.0 #P bookmarkplugin
247 247 248 248 return { 249 249 'realm': realm, 250 'url': url,250 'url': req.href(url), 251 251 'linkname': linkname, 252 252 'name': name, 253 253 'delete': req.href.bookmark('delete_in_page', url)}
However, I'm reminded on work I did on #7399 for the MenusPlugin. This fix won't work in the case that queries are bookmarked. When I bookmark I query, the result is:
So I'll look into working up a better patch tonight. It will be pretty much the same as what was done for #7399.
Attachments (2)
Change History (3)
Changed 13 years ago by
Attachment: | BookmarkPage.png added |
---|
Changed 13 years ago by
Attachment: | NoHandler.png added |
---|
comment:1 Changed 13 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Duplicate of #8628.