Support Trac 0.12 without ClearSilver

[Bangyou Zheng]

This plugin is wonderful. But It can not support Trac 0.12 without ClearSilver.

Current is there any plan to support Trac 0.12?

Thank you very much!

[Ryan J Ollos]

Genshi is a requirement for Trac 0.11 and later, see ​t:TracInstall#MandatoryDependencies. Do you mean that ClearSilver is still required? That should not be the case, see #3187, but it is still possible.

[trevor.w.ratliff@…]

I was able to get this plugin to work from the 2.2-dev branch with the attached diff file (peerreviewplugin_dev2_2_diff_Trac_0_12_2.diff). I hacked this together because I really liked this plugin, and I needed it to work in Trac 0.12.2.

It still isn't perfect, it doesn't handle multiple repositories properly (it will only see the first repo in your repository list), but it does what we need it to do. There are also some issues with the Genshi templates and trying to import other templates - so I just copied the functions into the template I needed (not good for maintainability).

[trevor.w.ratliff@…]

diff for fixing peer review plugin for trac 0.12.2

[Peter Stephens]

I got it to work on Fedora 16. Not professional. I have no Python experience, but it works. Note that I also had to get a clearsilver 'error.cs' file and put it at '/usr/lib/python2.7/site-packages/trac/templates/error.cs'.

Here is the code changes,

peerReviewPerform.py

@@ -30 +30 @@
 import string
 
 from genshi.builder import tag
+from trac.versioncontrol.api import RepositoryManager
 
 class UserbaseModule(Component):
     implements(INavigationContributor, IRequestHandler, ITemplateProvider, IHTMLPreviewAnnotator)
@@ -140 +141 @@
             return 'error.cs', None
 
         #get the respository
-        repos = self.env.get_repository(req.authname)
+        #repos = self.env.get_repository(req.authname)
+        repos = RepositoryManager(self.env).get_repository('')
         #get the file attributes
         req.hdf['review.path'] = resultFile.Path
         req.hdf['review.version'] = resultFile.Version

peerReviewBrowser.py

@@ -22 +22 @@
 from trac.web.chrome import add_link, add_stylesheet
 from trac.wiki import wiki_to_html, wiki_to_oneliner, IWikiSyntaxProvider
 from trac.versioncontrol.web_ui.util import *
+from trac.versioncontrol.api import RepositoryManager 
 
 from genshi.builder import tag
 
@@ -84 +85 @@
         path = req.args.get('path', '/')
         rev = req.args.get('rev')
 
-        repos = self.env.get_repository(req.authname)
+        repos = RepositoryManager(self.env).get_repository('') 
 
         try:
             node = get_existing_node(self.env, repos, path, rev)
         except:
-            rev = repos.youngest_rev
+            rev = repos.get_youngest_rev()
             node = get_existing_node(self.env, repos, path, rev)
        
         hidden_properties = [p.strip() for p
@@ -98 +99 @@
         req.hdf['title'] = path
         req.hdf['browser'] = {
             'path': path,
-            'revision': rev or repos.youngest_rev,
+            'revision': rev or repos.get_youngest_rev(),
             'props': dict([(util.escape(name), util.escape(value))
                            for name, value in node.get_properties().items()
                            if not name in hidden_properties]),
             'href': util.escape(self.env.href.peerReviewBrowser(path, rev=rev or
-                                                      repos.youngest_rev)),
+                                                      repos.get_youngest_rev())),
             'log_href': util.escape(self.env.href.log(path, rev=rev or None))

[Ryan J Ollos]

Replying to trevor.w.ratliff@gmail.com:

There are also some issues with the Genshi templates and trying to import other templates - so I just copied the functions into the template I needed (not good for maintainability).

Could you describe this problem in more detail?

[Cinc-th]

In 15173:

Preparation for multiple repos.

• Use RepositoryManager.get_repository()' instead of env.get_repository().
• Use get_youngest_rev() instead of youngest_rev

Refs #8800

[Cinc-th]

Replying to Cinc-th:

In 15173:

Preparation for multiple repos.

• Use RepositoryManager.get_repository()' instead of env.get_repository().
• Use get_youngest_rev() instead of youngest_rev

Refs #8800

This is not related to Clearsilver but makes the source more 0.12 like. Adds the patch from comment:4.

[Cinc-th]

The current trunk [15204] works for me with 0.12.3.