Modify ↓
Opened 13 years ago
#9587 new defect
Invalid HTTPNotFound call
Reported by: | Jonas Bardino | Owned by: | Martin Scharrer |
---|---|---|---|
Priority: | lowest | Component: | WikiCssPlugin |
Severity: | minor | Keywords: | |
Cc: | Jonas Bardino | Trac Release: | 0.11 |
Description
I think the minor change in Changeset 9159 introduces a small bug.
HTTPNotFound does not accept a named path argument, so the call in line 50 of tracwikicss/plugin.py
triggers a (harmless) log error for sites without a SiteStyle page:
2011-12-06 16:18:33,827 Trac[main] ERROR: Internal Server Error: Traceback (most recent call last): File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 450, in _dispatch_request dispatcher.dispatch(req) File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 206, in dispatch resp = chosen_handler.process_request(req) File "/usr/local/lib/python2.6/dist-packages/tracwikicss/plugin.py", line 50, in process_request raise HTTPNotFound(e, path=req.path_info) TypeError: __init__() got an unexpected keyword argument 'path'
and an error page when accessing the /wikicss.css URL directly:
Trac detected an internal error: TypeError: __init__() got an unexpected keyword argument 'path'
It should be changed to something like:
raise HTTPNotFound("%s path=%s" % (e, req.path_info))
which was verified to remove the problem yielding a proper log warning instead:
2011-12-06 16:49:54,955 Trac[main] WARNING: HTTPNotFound: 404 Not Found (WikiCss: Configured wiki page 'SiteStyle' doesn't exits. path=/wikicss.css)
Cheers, Jonas
System Information: User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.107 Safari/535.1 Trac: 0.11.7 Python: 2.6.6 (r266:84292, Dec 26 2010, 22:31:48) [GCC 4.4.5] setuptools: 0.6 SQLite: 3.7.3 pysqlite: 2.4.1 Genshi: 0.6 Pygments: 1.3.1 Mercurial: 1.6.4 FullBlog: 0.1.1-r9430 CustomFieldAdmin: 0.2.2 jQuery: 1.4.2
WikiCssPlugin 0.2 pip-installed from http://trac-hacks.org/svn/wikicssplugin/0.11
Attachments (0)
Note: See
TracTickets for help on using
tickets.