#7231 closed enhancement (fixed)
[Patch] Make label "Breadcrumbs:" configurable
| Reported by: | anonymous | Owned by: | hasienda |
|---|---|---|---|
| Priority: | normal | Component: | BreadCrumbsNavPlugin |
| Severity: | normal | Keywords: | custom label |
| Cc: | pipern | Trac Release: | 0.12 |
Description
Patch:
-
breadcrumbs.py
a b 23 23 supported_paths = ListOption('breadcrumbs', 'paths', '/wiki*,/ticket*,/milestone*', 24 24 doc='List of URL paths to allow breadcrumb tracking. Globs are supported.') 25 26 label = Option('breadcrumbs','label','Breadcrumbs:', 27 doc="""Text label to show before breadcrumb list""") 25 28 26 29 compiled_ignore_pattern = None … … 160 163 ) 161 164 162 insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh( "Breadcrumbs:"), li)165 insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh(self.label), li) 163 166 164 167 return stream | Transformer('//div[@id="metanav"]/ul').after(insert)
Attachments (0)
Change History (10)
comment:1 Changed 3 years ago by pipern
- Cc pipern added
comment:2 follow-up: ↓ 4 Changed 3 years ago by penmark
comment:3 Changed 3 years ago by rjollos
- Summary changed from Make label "Breadcrumbs:" configurable to [Patch] Make label "Breadcrumbs:" configurable
comment:4 in reply to: ↑ 2 Changed 3 years ago by hasienda
- Keywords custom label added; patch removed
Replying to penmark:
This issue is also addressed in
http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff
Sure, thanks for the pointer.
For the sake of completeness true i18n support providing localization according to configured languages in browser might still be preferred, making the label just an additional option, overwriting i18n label/per language once and for all users.
I'll put this on top of aforementioned patch soon.
comment:5 Changed 20 months ago by hasienda
- Owner changed from ixokai to hasienda
- Status changed from new to assigned
finally and visibly taking over responsibility after official maintainership change
comment:6 Changed 20 months ago by hasienda
(In [10892]) BreadCrumbsNavPlugin: Add configurable default list label, refs #7231 and #7790.
This modified version of the change suggested by anonymous reporter of #7231
and addressed in penmark's patch will work better with coming i18n support,
with the drawback, that the implicit default value isn't visible within the
configuration system. At least tried to address this by extending option doc.
comment:7 Changed 20 months ago by hasienda
- Resolution set to fixed
- Status changed from assigned to closed
comment:8 Changed 20 months ago by rjollos
Should I delete the two attachments on the BreadCrumbsNavPlugin wiki page?
comment:9 follow-up: ↓ 10 Changed 20 months ago by hasienda
comment:10 in reply to: ↑ 9 Changed 20 months ago by rjollos
Replying to hasienda:
So you can clean-up that wiki page now. Thanks for the suggestion.
Cleaned-up.


This issue is also addressed in
http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff