Ticket #7231 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

[Patch] Make label "Breadcrumbs:" configurable

Reported by: anonymous Assigned to: hasienda
Priority: normal Component: BreadCrumbsNavPlugin
Severity: normal Keywords: custom label
Cc: pipern Trac Release: 0.12

Description

Patch: 

--- a/breadcrumbs.py
+++ b/breadcrumbs.py
@@ -23,4 +23,7 @@
     supported_paths = ListOption('breadcrumbs', 'paths', '/wiki*,/ticket*,/milestone*',
         doc='List of URL paths to allow breadcrumb tracking. Globs are supported.')
+
+    label = Option('breadcrumbs','label','Breadcrumbs:',
+                   doc="""Text label to show before breadcrumb list""")
     
     compiled_ignore_pattern = None
@@ -160,5 +163,5 @@
             )
             
-        insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh("Breadcrumbs:"), li)
+        insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh(self.label), li)
 
         return stream | Transformer('//div[@id="metanav"]/ul').after(insert)

Attachments

Change History

06/10/10 11:09:39 changed by pipern

  • cc set to pipern.

(follow-up: ↓ 4 ) 09/01/10 18:04:34 changed by penmark

This issue is also addressed in http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff

09/01/10 21:12:42 changed by rjollos

  • summary changed from Make label "Breadcrumbs:" configurable to [Patch] Make label "Breadcrumbs:" configurable.

(in reply to: ↑ 2 ) 11/16/10 01:12:53 changed by hasienda

  • keywords changed from patch to custom label.

Replying to penmark:

This issue is also addressed in http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff

Sure, thanks for the pointer.

For the sake of completeness true i18n support providing localization according to configured languages in browser might still be preferred, making the label just an additional option, overwriting i18n label/per language once and for all users.

I'll put this on top of aforementioned patch soon.

11/09/11 00:59:39 changed by hasienda

  • owner changed from ixokai to hasienda.
  • status changed from new to assigned.

finally and visibly taking over responsibility after official maintainership change

11/09/11 01:11:44 changed by hasienda

(In [10892]) BreadCrumbsNavPlugin: Add configurable default list label, refs #7231 and #7790.

This modified version of the change suggested by anonymous reporter of #7231 and addressed in penmark's patch will work better with coming i18n support, with the drawback, that the implicit default value isn't visible within the configuration system. At least tried to address this by extending option doc.

11/09/11 21:02:25 changed by hasienda

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

11/09/11 21:25:42 changed by rjollos

Should I delete the two attachments on the BreadCrumbsNavPlugin wiki page?

(follow-up: ↓ 10 ) 11/10/11 20:39:36 changed by hasienda

I've just copied these patch files with a reference on their original submission to #7790 and new ticket #9539 respectively.

So you can clean-up that wiki page now. Thanks for the suggestion.

(in reply to: ↑ 9 ) 11/10/11 22:31:25 changed by rjollos

Replying to hasienda:

So you can clean-up that wiki page now. Thanks for the suggestion.

Cleaned-up.

Add/Change #7231 ([Patch] Make label "Breadcrumbs:" configurable)




Change Properties
Action