Ticket #9058 (assigned enhancement)

Opened 2 years ago

Last modified 2 years ago

Let `TAGS_MODIFY` inherited `TAGS_VIEW` for more intuitive permissions

Reported by: hasienda Assigned to: hasienda (accepted)
Priority: low Component: TagsPlugin
Severity: normal Keywords: permission inheritance
Cc: doki_pen, mitar, rjollos, robguttman, otaku42 Trac Release: 0.11

Description

Sure, Trac core, i.e. wiki permissions have no inheritance as well, and there are some good reasons for a high degree of privilege separation.

But it doesn't make any sense to give a modify permission without view, does it? In fact, you can hardly do one without the other, so there's no point to try, if not for diminishing the "joy" of hacking a ton of privileges per group/user for each Trac application you have to administrate.

So I speak up in favor of a sensible inheritance like so:

TAGS_VIEW remains just that: TAGS_VIEW TAGS_MODIFY gets extended to: TAGS_MODIFY + TAGS_VIEW

I'll happily provide the patch or the changeset to accomplish this, if it is acceptable and receives at least two more positive votes from fellow developers. Thanks for consideration.

Attachments

Change History

08/02/11 21:16:11 changed by hasienda

Bad formatting, sorry, have been too fast, so repeat just that once again:

TAGS_VIEW remains just that: TAGS_VIEW
TAGS_MODIFY gets extended to: TAGS_MODIFY + TAGS_VIEW

08/03/11 04:34:14 changed by robguttman

+1

Same for all *_VIEW and *_MODIFY permissions. Good suggestion, Steffen.

08/03/11 09:59:44 changed by mitar

+1

08/03/11 21:17:51 changed by rjollos

This has confused me in the past as well. Happy to see you'll be fixing it! +1

08/29/11 22:42:08 changed by hasienda

(In [10627]) TagsPlugin: Improve permission definition for more intuitive permission settings, refs #9058 and #9059.

Add a third permission TAGS_ADMIN for access to future 'tags' admin panel.

09/04/11 00:49:05 changed by hasienda

  • status changed from new to assigned.

While I'll build upon this now I'm still open to corrective or encouraging feedback before the tags-0.7 release. Thanks for taking care.

09/05/11 01:34:12 changed by hasienda

(In [10639]) TagsPlugin: Add tag mass replacement functionality, refs #9058, #9059 and #9061.

This is a modified version of code originally contributed by Itamar Ostricher. I felt like improving usability by replacing the input field for old tag(s) with a select box containing all currently defined tags, where even multiple selection and tag mass deletion is possible now.

Thank you for your truely inspiring work, Itamar.

Add/Change #9058 (Let `TAGS_MODIFY` inherited `TAGS_VIEW` for more intuitive permissions)




Change Properties
Action