Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#10729 closed defect (fixed)

Templates have hard-coded paths to stylesheets.

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: PeerReviewPlugin
Severity: trivial Keywords: chrome web_ui genshi templates
Cc: Olemis Lang, Yudivián Almeida Cruz, dm@… Trac Release:

Description

For example, peerReviewBrowser.html contains:

<link rel="stylesheet" href="/trac-mysql/chrome/common/css/code.css" type="text/css" media="screen, projector, print" />
<link rel="stylesheet" href="/trac-mysql/chrome/common/css/browser.css" type="text/css" media="screen, projector, print" />

Attachments (0)

Change History (9)

comment:1 Changed 5 years ago by Ryan J Ollos

Status: newassigned
Summary: Templates have hard-coded references to stylesheets.Templates have hard-coded paths to stylesheets.

comment:2 Changed 5 years ago by Ryan J Ollos

Cc: Emma added

The templates that should have these hard-coded link elements removed from head are: peerReviewBrowser.html, peerReviewCommentCallback.html, peerReviewMain.html, peerReviewOptions.html, peerReviewSearch.html and peerReviewView.html. If those stylesheets are needed in those templates, they should be added using a call to add_stylesheet. I haven't looked as to whether that is already done, and whether the stylesheets are being added everywhere they are needed.

If someone else would like to pickup this ticket and resolved the issue, feel free to do so.

comment:3 Changed 5 years ago by Olemis Lang

Cc: Ryan J Ollos added
Keywords: chrome web_ui genshi templates added
Owner: changed from Ryan J Ollos to Emma
Severity: normaltrivial
Status: assignednew

Thanks rjollos . I think this is a very good starting point for our work . Considering your previous I'll be assigning this ticket to extorue . Do not hesitate to change anything is there's a good reason for doing so .

comment:4 Changed 5 years ago by Ryan J Ollos

#10731 and #10782 may be good starting points for getting familiar with the codebase as well, and I wouldn't mind at all if someone beat me to implementing those ;)

comment:5 Changed 5 years ago by Olemis Lang

Owner: changed from Emma to Yudivián Almeida Cruz

comment:6 Changed 5 years ago by Olemis Lang

Cc: Yudivián Almeida Cruz added; Emma removed

comment:7 Changed 4 years ago by Ryan J Ollos

Cc: dm@… added; Ryan J Ollos removed
Owner: changed from Yudivián Almeida Cruz to Ryan J Ollos
Status: newassigned

comment:8 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

In 13502:

Add stylesheets using add_stylesheet. Fixes #10729.

This fixes some incorrect hard-coded paths in link elements in the templates.

comment:9 Changed 4 years ago by Ryan J Ollos

[13502#file0] is an unintended change, but I'm not going to worry about it since it's generally harmless and the branch won't be maintained.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.