Modify

Opened 8 years ago

Closed 6 years ago

#4454 closed enhancement (wontfix)

Change button should match style of Reply button and be positioned below the reply button

Reported by: J Evan S Owned by: Ryan J Ollos
Priority: normal Component: TicketChangePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Maintaining the same style would help with professional feel.

(Although keeping the label a different color might not be bad to minimize accidental hits.)

Attachments (1)

TicketChangePlugin.png (4.5 KB) - added by Ryan J Ollos 7 years ago.
Screen capture

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by kontakt@…

I'm using some custom CSS styles to improve my Trac experience anyways, so I've just added these lines to my custom style.css:

div.inlinebuttons a {
  border: 1px dotted #CCC;
  color: #222;
  font-size: 70%;
  margin: 0 0.1em;
  padding: 0.1em;
}

There's a 1px height difference compared to the Reply-Button that I've not yet managed to extinguish, but that's just my lazyness.

comment:2 Changed 8 years ago by Ryan J Ollos

Cc: Ryan J Ollos added; anonymous removed

comment:3 Changed 8 years ago by Ryan J Ollos

It might be useful to look at how this was done for the CloneTicketPlugin.

comment:4 Changed 7 years ago by Ryan J Ollos

Cc: anonymous added; Ryan J Ollos removed
Summary: Have Change buttons match style of Reply buttonsChange button should match style of Reply button

Screen capture with TicketChangePlugin, TicketDeletePlugin, and GamedevTheme installed.

Screen capture

Changed 7 years ago by Ryan J Ollos

Attachment: TicketChangePlugin.png added

Screen capture

comment:5 Changed 7 years ago by Ryan J Ollos

See also #5481.

comment:6 Changed 7 years ago by Ryan J Ollos

Resolution: duplicate
Status: newclosed

Closing as a duplicate since #5481 requests this feature.

comment:7 Changed 7 years ago by J Evan S

Well normally you might close the higher number ticket as the duplicate :-)

In this particular case they seem unique as this ticket is concerned with appearance while #5481 is primarily concerned with placement. Of course that doesn't mean that the same fix couldn't perhaps fix both.

Personally I prefer the layout of your attachment to this ticket over the layout shown in #5481, but perhaps that's just the difference in having a code block in the comment.

comment:8 Changed 7 years ago by Ryan J Ollos

Resolution: duplicate
Status: closedreopened
Summary: Change button should match style of Reply buttonChange button should match style of Reply button and be positioned below the reply button

That makes sense. Seems like they could both be handled in one fix, so I'll append the other fix to summary for this ticket.

comment:9 Changed 7 years ago by Ryan J Ollos

Also, hoping to get this fixed soon, see #6628.

comment:10 Changed 6 years ago by Ryan J Ollos

Owner: changed from Sergei Luchko to Ryan J Ollos
Status: reopenednew

comment:11 Changed 6 years ago by Ryan J Ollos

Status: newassigned

comment:12 Changed 6 years ago by Ryan J Ollos

Resolution: wontfix
Status: assignedclosed

Closing as wontfix since the functionality has been integrated into the Trac core. See the news on the plugin's main page.

Modify Ticket

Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.