Modify

Opened 5 years ago

Closed 3 days ago

#8415 closed enhancement (fixed)

Allow to modify a Code Review once submitted for PeerReviewPlugin

Reported by: canh.tran@… Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by rjollos)

  1. Please add a feature to allow adding/removing file(s) if you're the author of a Code Review.
  2. CODE_REVIEW_MGR user can add or remove file(s) as long as Code Review is not closed.

Attachments (0)

Change History (11)

comment:1 Changed 5 years ago by anonymous

  • Priority changed from normal to high
  • Severity changed from normal to major

comment:2 Changed 5 years ago by canh.tran@…

Also if there is an option to delete existing code review from the system similar like delete a ticket through trac-admin will be great. Thanks.

comment:3 Changed 5 years ago by andersm

  • Owner changed from proofek to andersm

comment:4 Changed 4 years ago by rjollos

  • Description modified (diff)
  • Priority changed from high to normal
  • Severity changed from major to normal
  • Type changed from defect to enhancement

comment:5 Changed 3 months ago by Cinc-th

  • Owner changed from andersm to Cinc-th
  • Status changed from new to assigned
  • Summary changed from Allow to add/remove file(s) in Code Review once submitted for PeerReviewPlugin to Allow to modify a Code Review once submitted for PeerReviewPlugin
  • Trac Release changed from 0.11 to 0.12

It should also be possible to change the list of reviewers and name and notes.

comment:6 Changed 3 months ago by Cinc-th

In 15207:

  • Allow to modify the user list, name and notes of a review.
  • Moved user list to own template
  • Some refactorings wrt user list

Refs #8415

See also #2841 which is about adding/removing users.

Last edited 3 months ago by Cinc-th (previous) (diff)

comment:7 Changed 3 months ago by Cinc-th

  • Users who already voted or commented on a file can't be removed from a review.
  • As of [15207] it's still possible to change a review after closing.

comment:8 Changed 3 months ago by Cinc-th

In 15208:

  • prevent modification of closed reviews
  • prevent creation of comments for closed reviews. This is a crude workaround for now.

Refs #8415

comment:9 Changed 3 months ago by Cinc-th

In 15216:

Don't overwrite review notes with resubmit message when trying to modify a review.

Refs #8415

comment:10 Changed 3 months ago by Cinc-th

In 15226:

Allow removal of files when modifying a review. Only files without comments may be removed.

Refs #8415

comment:11 Changed 3 days ago by Cinc-th

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.